685605 - Replace references to obsolete functions convert_config and filter_params

Status: RESOLVED FIXED

(Cloud Services :: Server: Key Exchange, defect)

Description

[Ryan Tilder [:rtilder]]

Attachment: Replace calls to convert_config and filter_params

Jenkins has been complaining about the key-exchange builds failing.  This is at least one part of it.

keyexchange/wsgiapp.py needs to use the newer Config object instead of convert_config and filter_params.

Comment 1

[Ryan Tilder [:rtilder]]

Pushed in http://hg.mozilla.org/services/server-key-exchange/rev/d832b671bcba

Realized that doesn't fix it though.

Comment 2

[Ryan Tilder [:rtilder]]

Attachment: Fix a stupid typo and a thinko

Comment 3

[Ryan Tilder [:rtilder]]

Attachment: Fix for stupid type and two thinkos

A lesson learned: use only one editor per project.

Comment 4

[Rob Miller [:rmiller]]

Comment on attachment 559316 [details] [diff] [review]
Fix for stupid type and two thinkos

Review of attachment 559316 [details] [diff] [review]:
-----------------------------------------------------------------

this makes sense when taken cumulatively w/ the last patch (https://bugzilla.mozilla.org/page.cgi?id=splinter.html&bug=685605&attachment=559219)

Comment 5

[Ryan Tilder [:rtilder]]

(In reply to Ryan Tilder [:rtilder] from comment #3)
> Created attachment 559316 [details] [diff] [review]
> Fix for stupid type and two thinkos
> 

Should make a note that these changes are cumulative with the attachment 559219 [details] [diff] [review].

Comment 6

[Ryan Tilder [:rtilder]]

Fixed in http://hg.mozilla.org/services/server-key-exchange/rev/846cbacd1ac2