Replace references to obsolete functions convert_config and filter_params

RESOLVED FIXED

Status

Cloud Services
Server: Key Exchange
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: rtilder, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

7 years ago
Created attachment 559219 [details] [diff] [review]
Replace calls to convert_config and filter_params

Jenkins has been complaining about the key-exchange builds failing.  This is at least one part of it.

keyexchange/wsgiapp.py needs to use the newer Config object instead of convert_config and filter_params.
Attachment #559219 - Flags: review?(rmiller)
Attachment #559219 - Flags: review?(rmiller) → review+
(Reporter)

Comment 1

7 years ago
Pushed in http://hg.mozilla.org/services/server-key-exchange/rev/d832b671bcba

Realized that doesn't fix it though.
(Reporter)

Comment 2

7 years ago
Created attachment 559315 [details] [diff] [review]
Fix a stupid typo and a thinko
Attachment #559315 - Flags: review?(rmiller)
(Reporter)

Comment 3

7 years ago
Created attachment 559316 [details] [diff] [review]
Fix for stupid type and two thinkos

A lesson learned: use only one editor per project.
Attachment #559315 - Attachment is obsolete: true
Attachment #559315 - Flags: review?(rmiller)
(Reporter)

Updated

7 years ago
Attachment #559316 - Flags: review?(rmiller)
(Reporter)

Updated

7 years ago
Attachment #559316 - Flags: review?(rmiller)
Comment on attachment 559316 [details] [diff] [review]
Fix for stupid type and two thinkos

Review of attachment 559316 [details] [diff] [review]:
-----------------------------------------------------------------

this makes sense when taken cumulatively w/ the last patch (https://bugzilla.mozilla.org/page.cgi?id=splinter.html&bug=685605&attachment=559219)
Attachment #559316 - Flags: review?(rmiller)
Attachment #559316 - Flags: review+
(Reporter)

Comment 5

7 years ago
(In reply to Ryan Tilder [:rtilder] from comment #3)
> Created attachment 559316 [details] [diff] [review]
> Fix for stupid type and two thinkos
> 

Should make a note that these changes are cumulative with the attachment 559219 [details] [diff] [review].
(Reporter)

Comment 6

7 years ago
Fixed in http://hg.mozilla.org/services/server-key-exchange/rev/846cbacd1ac2
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.