685738 - Footer in Thunderbird login page is ugly

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[krupa raj[:krupa]]

Attachment: screenshot

steps to reproduce:
1. Load https://addons-dev.allizom.org/en-US/thunderbird/users/login?to=%2Fen-US%2Fthunderbird%2F
2. Check out the footer


actual behavior:
Footer is hanging in the air leaving vast stretches of ugly whiteness. See screenshot.

Comment 1

[Jeff Balogh (:jbalogh)]

(In reply to krupa raj 82[:krupa] from comment #0)
> vast stretches of ugly whiteness. 

That's kind of offensive, you know.

Comment 2

[Christopher Van Wiemeersch [:cvan]]

This has been fixed. On apps pages (with the slim footer) we still have the ugly whiteness.

But for non-apps pages, the footer is now way at the bottom of the page. (And yes, Krupa, I'll make the footer at the bottom of the page so you don't have to scroll down to see it.)

Comment 3

[Jeff Balogh (:jbalogh)]

(In reply to Chris Van Wiemeersch [:cvan] from comment #2)
> This has been fixed. On apps pages (with the slim footer) we still have the
> ugly whiteness.
> 
> But for non-apps pages, the footer is now way at the bottom of the page.
> (And yes, Krupa, I'll make the footer at the bottom of the page so you don't
> have to scroll down to see it.)

This doesn't sound very fixed. You replaced empty space under the footer with a bunch of empty space above the footer.

Comment 4

[Potch [:potch]]

The footer will now attach itself to the bottom of the viewport when the content is shorter than the viewport. Yay!

https://github.com/jbalogh/zamboni/commit/64f360d

Comment 5

[Potch [:potch]]

re-opened due to https://github.com/jbalogh/zamboni/commit/f00f93f

Comment 6

[Potch [:potch]]

and lo, the beast was slain: 

https://github.com/mozilla/zamboni/commit/2909551000c6c