Last Comment Bug 685786 - give nsPresShell a .h file
: give nsPresShell a .h file
Product: Core
Classification: Components
Component: Layout (show other bugs)
: Trunk
: All All
P4 normal (vote)
: mozilla9
Assigned To: David Baron :dbaron: ⌚️UTC-8
: Jet Villegas (:jet)
Depends on:
  Show dependency treegraph
Reported: 2011-09-08 21:39 PDT by David Baron :dbaron: ⌚️UTC-8
Modified: 2011-09-09 22:41 PDT (History)
3 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

patch (71.61 KB, patch)
2011-09-08 21:39 PDT, David Baron :dbaron: ⌚️UTC-8
roc: review+
Details | Diff | Splinter Review

Description User image David Baron :dbaron: ⌚️UTC-8 2011-09-08 21:39:24 PDT
Created attachment 559383 [details] [diff] [review]

nsPresShell currently has the class definition in the .cpp file rather than in a .h file.  Having the class definition in a .h file is the first step towards merging nsPresShell into nsPresContext step-by-step.

I've had this patch in my tree for a while; may as well land it.
Comment 1 User image Robert O'Callahan (:roc) (email my personal email if necessary) 2011-09-08 21:52:12 PDT
Comment on attachment 559383 [details] [diff] [review]

Review of attachment 559383 [details] [diff] [review]:

You could reduce the diff and preserve some history using "hg copy", I guess.
Comment 2 User image David Baron :dbaron: ⌚️UTC-8 2011-09-09 12:53:50 PDT
Comment 3 User image Justin Wood (:Callek) [away until Feb 27] 2011-09-09 22:41:50 PDT
(In reply to David Baron [:dbaron] from comment #2)

and now on m-c

Note You need to log in before you can comment on or make changes to this bug.