Last Comment Bug 685786 - give nsPresShell a .h file
: give nsPresShell a .h file
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Layout (show other bugs)
: Trunk
: All All
: P4 normal (vote)
: mozilla9
Assigned To: David Baron :dbaron: ⌚️UTC-10
:
: Jet Villegas (:jet)
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-09-08 21:39 PDT by David Baron :dbaron: ⌚️UTC-10
Modified: 2011-09-09 22:41 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (71.61 KB, patch)
2011-09-08 21:39 PDT, David Baron :dbaron: ⌚️UTC-10
roc: review+
Details | Diff | Splinter Review

Description David Baron :dbaron: ⌚️UTC-10 2011-09-08 21:39:24 PDT
Created attachment 559383 [details] [diff] [review]
patch

nsPresShell currently has the class definition in the .cpp file rather than in a .h file.  Having the class definition in a .h file is the first step towards merging nsPresShell into nsPresContext step-by-step.

I've had this patch in my tree for a while; may as well land it.
Comment 1 Robert O'Callahan (:roc) (email my personal email if necessary) 2011-09-08 21:52:12 PDT
Comment on attachment 559383 [details] [diff] [review]
patch

Review of attachment 559383 [details] [diff] [review]:
-----------------------------------------------------------------

You could reduce the diff and preserve some history using "hg copy", I guess.
Comment 2 David Baron :dbaron: ⌚️UTC-10 2011-09-09 12:53:50 PDT
http://hg.mozilla.org/integration/mozilla-inbound/rev/ba84d2ccc09c
Comment 3 Justin Wood (:Callek) 2011-09-09 22:41:50 PDT
(In reply to David Baron [:dbaron] from comment #2)
> http://hg.mozilla.org/integration/mozilla-inbound/rev/ba84d2ccc09c

and now on m-c

Note You need to log in before you can comment on or make changes to this bug.