Closed Bug 686019 Opened 9 years ago Closed 9 years ago

Add support for testing addon sync in TPS

Categories

(Testing Graveyard :: TPS, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla11

People

(Reporter: jgriffin, Assigned: jgriffin)

References

Details

(Whiteboard: [fixed in services][qa-])

Attachments

(1 file, 1 obsolete file)

This is so TPS tests can be written for bug 534956.
Attached patch Add addon support to TPS, v0.1 (obsolete) — Splinter Review
This patch adds partial support for addons to TPS.  TPS tests can now add addons to a profile, and verify that addons are present.  The current patch works with real addons from AMO, as it's my understanding those are all that Sync will support in the first iteration, based on reading the patch in bug 534956.

Eventually we might (?) want to add the ability to mimic AMO so that we don't rely on it.

The current test, test_addons_sanity.js, passes; it 'tests' the addon support in TPS without requiring Sync support for addons to be working.

If the current approach looks reasonable, I'll add support for removing and updating addons as well.
Assignee: nobody → jgriffin
Status: NEW → ASSIGNED
Attachment #561350 - Flags: feedback?(gps)
(In reply to Jonathan Griffin (:jgriffin) from comment #1)
> This patch adds partial support for addons to TPS.

Nice!

> TPS tests can now add
> addons to a profile, and verify that addons are present.  The current patch
> works with real addons from AMO, as it's my understanding those are all that
> Sync will support in the first iteration, based on reading the patch in bug
> 534956.

Don't we also support addons whose original install location we know? E.g. Adblock Plus is hosted elsewhere but I think the AddonManager remembers the URL of the XPI and we sync that. Greg might know this better, though.
This version adds support for enabling, disabling, and uninstalling addons.  Also, removes dependency on AMO by running a local HTTP server to serve results that are requested using AddonRepository.getAddonsByIDs.

Probably a few more things need to be added, like support for addons installed during startup, and ability to verify addon versions for upgrade testing, but this is a good start.
Attachment #561350 - Attachment is obsolete: true
Attachment #561350 - Flags: feedback?(gps)
Attachment #566105 - Flags: feedback?(gps)
jgriffin: looks pretty good to me. Ive run it & am using it.
Attachment #566105 - Flags: feedback?(mconnor)
Comment on attachment 566105 [details] [diff] [review]
Add addon support to TPS, v0.2

Looks good, ship it.
Attachment #566105 - Flags: review+
Attachment #566105 - Flags: feedback?(mconnor)
Attachment #566105 - Flags: feedback?(gps)
https://hg.mozilla.org/mozilla-central/rev/a0752c7b4bcf
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
thank you mconnor & rnewman
Status: RESOLVED → UNCONFIRMED
Ever confirmed: false
Resolution: FIXED → ---
Target Milestone: mozilla11 → ---
Status: UNCONFIRMED → RESOLVED
Closed: 9 years ago9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
Blocks: 704642
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.