686019 - Add support for testing addon sync in TPS

Status: RESOLVED FIXED

(Testing Graveyard :: TPS, defect)

Description

[Jonathan Griffin (:jgriffin)]

This is so TPS tests can be written for bug 534956.

Comment 1

[Jonathan Griffin (:jgriffin)]

Attachment: Add addon support to TPS, v0.1

This patch adds partial support for addons to TPS.  TPS tests can now add addons to a profile, and verify that addons are present.  The current patch works with real addons from AMO, as it's my understanding those are all that Sync will support in the first iteration, based on reading the patch in bug 534956.

Eventually we might (?) want to add the ability to mimic AMO so that we don't rely on it.

The current test, test_addons_sanity.js, passes; it 'tests' the addon support in TPS without requiring Sync support for addons to be working.

If the current approach looks reasonable, I'll add support for removing and updating addons as well.

Comment 2

[Philipp von Weitershausen [:philikon]]

(In reply to Jonathan Griffin (:jgriffin) from comment #1)
> This patch adds partial support for addons to TPS.

Nice!

> TPS tests can now add
> addons to a profile, and verify that addons are present.  The current patch
> works with real addons from AMO, as it's my understanding those are all that
> Sync will support in the first iteration, based on reading the patch in bug
> 534956.

Don't we also support addons whose original install location we know? E.g. Adblock Plus is hosted elsewhere but I think the AddonManager remembers the URL of the XPI and we sync that. Greg might know this better, though.

Comment 3

[Jonathan Griffin (:jgriffin)]

Attachment: Add addon support to TPS, v0.2

This version adds support for enabling, disabling, and uninstalling addons.  Also, removes dependency on AMO by running a local HTTP server to serve results that are requested using AddonRepository.getAddonsByIDs.

Probably a few more things need to be added, like support for addons installed during startup, and ability to verify addon versions for upgrade testing, but this is a good start.

Comment 4

[Allison Naaktgeboren :ally]

jgriffin: looks pretty good to me. Ive run it & am using it.

Comment 5

[Mike Connor [:mconnor]]

Comment on attachment 566105 [details] [diff] [review]
Add addon support to TPS, v0.2

Looks good, ship it.

Comment 6

[Richard Newman [:rnewman]]

Landed:

https://hg.mozilla.org/services/services-central/rev/a0752c7b4bcf

Comment 7

[Richard Newman [:rnewman]]

https://hg.mozilla.org/mozilla-central/rev/a0752c7b4bcf

Comment 8

[Allison Naaktgeboren :ally]

thank you mconnor & rnewman