Closed
Bug 686189
Opened 13 years ago
Closed 13 years ago
Replace nsCStringArray in mailnews/db with nsTArray counterparts
Categories
(MailNews Core :: Database, defect)
MailNews Core
Database
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 10.0
People
(Reporter: standard8, Assigned: standard8)
Details
Attachments
(1 file, 1 obsolete file)
|
10.49 KB,
patch
|
Bienvenu
:
review+
|
Details | Diff | Splinter Review |
nsCStringArray is getting old and obsolete, this helps removing it get a bit further along.
Attachment #559739 -
Flags: review?(dbienvenu)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 559739 [details] [diff] [review] The fix when I build this on Windows, I get a link error with safeElementAt - have you tried building on Windows?
|
|
||
Comment 2•13 years ago
|
||
(In reply to David :Bienvenu from comment #1) > Comment on attachment 559739 [details] [diff] [review] > The fix > > when I build this on Windows, I get a link error with safeElementAt - have > you tried building on Windows? Have you been able to reproduce the link error? I'd hate to be holding up this patch because of an error on my part, or a problem with dependency builds...
|
Assignee | |
Comment 3•13 years ago
|
||
Comment on attachment 559739 [details] [diff] [review] The fix Yeah this broke all platforms, and needs some tweaking.
Attachment #559739 -
Flags: review?(dbienvenu)
|
|
Assignee | |
Comment 4•13 years ago
|
||
Updated patch which also includes nsAbLDAPAutoCompFormatter changes.
Attachment #559739 -
Attachment is obsolete: true
Attachment #565485 -
Flags: review?(dbienvenu)
|
|
||
Updated•13 years ago
|
Attachment #565485 -
Flags: review?(dbienvenu) → review+
|
|
Assignee | |
Comment 5•13 years ago
|
||
Checked in: http://hg.mozilla.org/comm-central/rev/4c5d0bf41249
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 10.0
You need to log in
before you can comment on or make changes to this bug.
Description
•