lack of arch-specific compiler flags in security/coreconf/Linux.mk

VERIFIED INVALID

Status

P3
major
VERIFIED INVALID
18 years ago
2 years ago

People

(Reporter: antitux, Assigned: ddrinan0264)

Tracking

1.0 Branch
Future

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

18 years ago
I did the official build of mozilla 0.7 for linux-sparc64, and came across a
peculiar problem.

Originally, there were no arch-specific compile flags for PSM in
linux-sparc/sparc64, so when trying to make the official build, PSM wouldn't
compile. I submitted a patch, which is still on Duke34.mcom.com, and was emailed
back told that the problem was already solved.

I think that the that was went about solving it was flawed.

My reasoning behind this is that instead of adding arch-specific compile flags,
you added generic ones, causing PSM to run at approximately 25% slower speed.
I'm putting another patch on http://Duke34.mcom.com to show how I believe that
the original patch SHOULD have been done.

This might also solve you issues with compiles of PSM, if you're still looking
at those.

The new patch is located at
http://duke34.mcom.com/architecture-compile-optimizations-Linux.mk.PATCH

If you have any problems/comments/concerns, please contact me.
Thanks
(Reporter)

Comment 1

18 years ago
Created attachment 25107 [details] [diff] [review]
arch-specific compile patches

Comment 2

18 years ago
Marking NEW to get someone to look and review the patch.
Severity: normal → major
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: patch, review
(Reporter)

Comment 3

18 years ago
I bass-ackwarded the patch,
the fixed one is on http://bofh1.mcom.com

Comment 4

18 years ago
Reporter, is this still a problem now that PSM 2.0 is integrated into the 
nightly builds?

Comment 5

17 years ago
-> 2.0
-> P3
Priority: -- → P3
Target Milestone: --- → 2.0

Comment 6

17 years ago
version 2.0
target 2.1
Target Milestone: 2.0 → 2.1
Version: unspecified → 2.0

Updated

17 years ago
Keywords: nsenterprise

Comment 7

17 years ago
Moving all P3 and P4 bugs targetted to 2.1 to future.
Target Milestone: 2.1 → Future

Comment 8

17 years ago
removing nsenterprise keyword from PSM bugs with target milestone of future.
Keywords: nsenterprise

Comment 9

17 years ago
Mass assigning QA to ckritzer.
QA Contact: junruh → ckritzer

Comment 10

17 years ago
Marking invalid, since there has been no comment from the reporter in 6 months. 
Reporter, please reopen if there is still a problem.
Status: NEW → RESOLVED
Last Resolved: 17 years ago
QA Contact: ckritzer → junruh
Resolution: --- → INVALID
(Reporter)

Comment 11

17 years ago
nah, that's cool.

Comment 12

17 years ago
Verified.
Status: RESOLVED → VERIFIED

Updated

14 years ago
Component: Security: UI → Security: UI
Product: PSM → Core

Updated

10 years ago
Version: psm2.0 → 1.0 Branch
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.