686333 - Bugzilla login field should be <input type=email>

Status: RESOLVED FIXED

(Bugzilla :: User Interface, enhancement)

Description

[:Atoll]

Every time I try to login to bugzilla on a mobile device, it screws up my email address and autocapitalizes it and corrects spellings and screws it all up.

Please change the input type of our b.m.o login username fields from "text" to "email" so that the mobile users have an easier experience filing mobile bugs from mobile devices.

I understand there may be some sort of big "convert everything to html5" project in development, but this one simple change would be a big help until the rest of the project lands.

Comment 1

[David Lawrence [:dkl]]

moving to upstream as bmo trys to stay in sync and other upstream contributors may want to discuss a more general solution.

Comment 2

[Frédéric Buclin]

We won't do this till we move to HTML5. type="email" doesn't exist in HTML4.

Comment 3

[:Atoll]

feel free to resolve as dupe of html5 bug, then. was not aware that bugzilla is not permitted to use html5 elements, sorry.

Comment 4

[Max Kanat-Alexander]

What happens if we just use type="email" with an HTML4 doctype? If it doesn't cause issues in UAs, it's fine with me.

Comment 5

[:Atoll]

(In reply to Max Kanat-Alexander from comment #4)
> What happens if we just use type="email" with an HTML4 doctype? If it
> doesn't cause issues in UAs, it's fine with me.

All existing UAs seem degrade to <input type="text"> when an unknown input type is specified. I think that behavior goes all the way back to the Very Old Days.

Comment 6

[:glob ✱]

won't this cause problems for sites where email != login?

Comment 7

[:Atoll]

(In reply to Byron Jones ‹:glob› from comment #6)
> won't this cause problems for sites where email != login?

If Bugzilla has a preference that permits non-email logins, then this form type would need to be hinted by that preference to either text or email, depending.

Comment 9

[Frédéric Buclin]

Attachment: patch, v1

Comment 10

[:Atoll]

Comment on attachment 8357373 [details] [diff] [review]
patch, v1

Review of attachment 8357373 [details] [diff] [review]:
-----------------------------------------------------------------

This patch seems like a valid solution for my request, and has bonus EOL whitespace cleanups.

Comment 11

[Dave Miller [:justdave]]

Comment on attachment 8357373 [details] [diff] [review]
patch, v1

looks good.

Comment 12

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified template/en/default/account/create.html.tmpl
modified template/en/default/account/auth/login.html.tmpl
modified template/en/default/account/prefs/account.html.tmpl
Committed revision 8868.

Comment 13

[:Atoll]

I'm not seeing this on BMO. Should I reopen this bug, or clone it to the BMO product?

Found two inputs so far missing the email attribute:

<input id="Bugzilla_login_top" class="bz_login" name="Bugzilla_login" title="Login" placeholder="email address">

<input size="35" id="Bugzilla_login" name="Bugzilla_login">

Comment 14

[scholi]

We are using LDAP uid as login name for bugzilla and our users can't login now because most browsers check for type="email". I think this needs to be fixed.

Comment 15

[Frédéric Buclin]

(In reply to scholi from comment #14)
> We are using LDAP uid as login name for bugzilla and our users can't login
> now because most browsers check for type="email". I think this needs to be
> fixed.

This is discussed in bug 1164398.