686357 - TPS creates files outside the obj dir

Status: RESOLVED FIXED

(Testing Graveyard :: TPS, defect)

Description

[Richard Newman [:rnewman]]

Attachment: Proposed patch. v1

Comment 1

[Philipp von Weitershausen [:philikon]]

Comment on attachment 559896 [details] [diff] [review]
Proposed patch. v1

Why does TPS write things outside the obj dir anyway? I'd rather fix this at the root than hide the spew.

Comment 2

[Jonathan Griffin (:jgriffin)]

tps.log gets written to the curdir wherever runtps is invoked from, unless overridden with the --logfile option.  The other files are side effects of calling python setup.py on tps; I'll modify INSTALL.sh to clean those up.

Comment 3

[Jonathan Griffin (:jgriffin)]

Attachment: Proposed patch v.2

Here's a version which prevents TPS from writing any files to locations other than its virtualenv, except for tps.log, which by default is written to the current directory.  You can invoke runtps from any directory, so you can avoid tps.log in the src dir by not invoking runtps there, or by passing it the --logfile options.

Comment 4

[Richard Newman [:rnewman]]

Comment on attachment 559972 [details] [diff] [review]
Proposed patch v.2

Beautiful. Thanks, jgriffin.

Comment 5

[Jonathan Griffin (:jgriffin)]

Landed as http://hg.mozilla.org/services/services-central/rev/272a1113b4d1