TPS creates files outside the obj dir

RESOLVED FIXED

Status

defect
RESOLVED FIXED
8 years ago
Last year

People

(Reporter: rnewman, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Posted patch Proposed patch. v1 (obsolete) — Splinter Review
No description provided.
Attachment #559896 - Flags: review?(jgriffin)
Comment on attachment 559896 [details] [diff] [review]
Proposed patch. v1

Why does TPS write things outside the obj dir anyway? I'd rather fix this at the root than hide the spew.
Attachment #559896 - Flags: feedback-
tps.log gets written to the curdir wherever runtps is invoked from, unless overridden with the --logfile option.  The other files are side effects of calling python setup.py on tps; I'll modify INSTALL.sh to clean those up.
Here's a version which prevents TPS from writing any files to locations other than its virtualenv, except for tps.log, which by default is written to the current directory.  You can invoke runtps from any directory, so you can avoid tps.log in the src dir by not invoking runtps there, or by passing it the --logfile options.
Attachment #559896 - Attachment is obsolete: true
Attachment #559896 - Flags: review?(jgriffin)
Attachment #559972 - Flags: review?(rnewman)
Summary: Ignore TPS build output in Mercurial → TPS creates files outside the obj dir
Comment on attachment 559972 [details] [diff] [review]
Proposed patch v.2

Beautiful. Thanks, jgriffin.
Attachment #559972 - Flags: review?(rnewman) → review+
Assignee: rnewman → jgriffin
Landed as http://hg.mozilla.org/services/services-central/rev/272a1113b4d1
Assignee: jgriffin → nobody
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.