686425 - Log not available should never be cached

Status: RESOLVED INCOMPLETE

(Tree Management Graveyard :: TBPL, defect)

Description

[Phil Ringnalda (:philor)]

Two related things, that I think are close enough to file together though I wouldn't object if someone fixing just one of them wanted to push the other out to another bug.

It's possible for the status of a job from buildbot to race the log being uploaded. When that happens, two things can happen to the user:

* Click on the letter for the failed job, and you get a summary popup telling you that the log isn't available. That apparently isn't cached on the server side, but is on the client side, so every time you go back to the letter it will still immediately tell you the same thing, but if you refresh the tbpl page, then it will fetch up the summary next time you click on the letter.

* Click on a View (brief|full) log link, and getParsedLog.php will send you a cacheable page saying that the log is not available. Close it, reopen it five minutes later, it'll still say the same thing, unless you know to refresh it, in which case you'll get the log.

Comment 1

[Arpad Borsos [:Swatinem]]

Do you mean cached on the server or on the client via headers?

Comment 2

[Phil Ringnalda (:philor)]

Client in both cases, near as I can tell.

Comment 3

[Ed Morley [:emorley]]

Haven't seen this for ages / TBPL2 coming anyway.