Closed
Bug 686469
Opened 13 years ago
Closed 13 years ago
Tab-modal alert can overflow the browser window
Categories
(Toolkit :: UI Widgets, defect)
Tracking
()
VERIFIED
FIXED
mozilla10
People
(Reporter: glibnes, Assigned: dao)
References
Details
(Keywords: regression, verified-aurora, verified-beta, Whiteboard: [qa!])
Attachments
(3 files)
14.16 KB,
image/png
|
Details | |
926 bytes,
text/html
|
Details | |
1.60 KB,
patch
|
Dolske
:
review+
asa
:
approval-mozilla-aurora+
christian
:
approval-mozilla-beta-
|
Details | Diff | Splinter Review |
This Bug happened when I was using PhpMyAdmin (works on every version). If text in Alert (JS: alert()) is very, very long, it can go out of the screen. In that case, you won't be able to see OK Button.
Updated•13 years ago
|
Attachment #559970 -
Attachment mime type: text/plain → text/html
Comment 2•13 years ago
|
||
wfm with Mozilla/5.0 (Windows NT 6.1; rv:9.0a1) Gecko/20110912 Firefox/9.0a1 SeaMonkey/2.6a1
I have tried on the same version of Nightly as you did, but bug is still present. When I have runed fresh profile for the first time, it showed in normal way, but after the next reload it showed up just like on the Screenshot. Maybe it's somehow connected with my Screen Resolution (I'm using 1920x1080), my Windows font-size is set to 125%. Generaly I'm using Firefox Maximized.
Comment 4•13 years ago
|
||
Able to reproduce on Mozilla/5.0 (Windows NT 5.1; rv:9.0a1) Gecko/20110913 Firefox/9.0a1 ID:20110913030846 with resolution set to 1920 x 1200 - no change in font size in my setup
Comment 5•13 years ago
|
||
marking new based on comment#4
Status: UNCONFIRMED → NEW
Component: General → Widget: Win32
Ever confirmed: true
Product: Firefox → Core
QA Contact: general → win32
Updated•13 years ago
|
Keywords: regression
Comment 6•13 years ago
|
||
Works for me in Firefox Release (6.0) I can reproduce the problem in all of Firefox Beta (7.0), Aurora (8.0), and Nightly (9.0)
Comment 7•13 years ago
|
||
This works in Seamonkey but fails in Firefox Last good nightly: 2011-07-01 First bad nightly: 2011-07-02 Pushlog: <http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=beceddeee3f4&tochan ge=549e3276ed25>
Comment 8•13 years ago
|
||
Just found the same :)
Comment 9•13 years ago
|
||
Just a guess; Could this be either the checkin from Ddao or smaug ?
Comment 10•13 years ago
|
||
I think it's probably Kai's in Bug 431078. I'll verify this shortly.
Comment 11•13 years ago
|
||
I just seen the one in Windows widget without reading the commit messages :) Sorry you're probably right about Bug 668500, will check shortly.
Comment 12•13 years ago
|
||
Confirmed that the regression was introduced in: Bug 668500 - Scrollbars appear if the notificationbox overflows We may want to backout changeset http://hg.mozilla.org/mozilla-central/rev/4a10fb9c4b34 before this hits release on September 27th?
Assignee | ||
Comment 13•13 years ago
|
||
The tab-modal alert implementation seems to assume that it's in a container (e.g. <notificationbox>) that overflows in a special way.
Blocks: 668500
Component: Widget: Win32 → General
OS: Windows 7 → All
Product: Core → Toolkit
QA Contact: win32 → general
Hardware: x86_64 → All
Assignee | ||
Updated•13 years ago
|
Component: General → XUL Widgets
QA Contact: general → xul.widgets
Version: 8 Branch → 7 Branch
Assignee | ||
Comment 14•13 years ago
|
||
The dependency on <notificationbox> is even more explicit than I expected it to be.
Assignee | ||
Updated•13 years ago
|
Assignee | ||
Updated•13 years ago
|
Summary: Alert can be wider than the Screen width → Tab-modal alert can overflow the browser window
Comment 16•13 years ago
|
||
Comment on attachment 560882 [details] [diff] [review] patch Review of attachment 560882 [details] [diff] [review]: ----------------------------------------------------------------- Hmm. So the fix to bug 668500 caused this to break? I noticed one interesting quirk on trunk with the testcases I wrote for bug 613749 (which implemented the support for limiting the prompt's size)... With the "Wordy" and "XtraWordy" testcases the line breaks -- once -- and the prompt overflows at small enough window sizes. [And snaps to the correct size as soon as you resize the window.] But even with a super-narrow window, the line only breaks once. I'm not sure I understand why it fails that way, do you? I also noticed some glitchy prompt sizing when resizing on some of the above tests (like it will bounce between showing 2 lines + 1 scrollbar and multiple lines with a vertical scrollbar), but it seems to be doing the same thing on FF6 so it's no worse. Frank, we some of those known from the original landing? I can't remember.
Attachment #560882 -
Flags: review?(dolske) → review+
Comment 17•13 years ago
|
||
Forgot to note: my last paragraph in comment 16 refers to my local build with this patch.
Assignee | ||
Comment 18•13 years ago
|
||
(In reply to Justin Dolske [:Dolske] from comment #16) > Comment on attachment 560882 [details] [diff] [review] [diff] [details] [review] > patch > > Review of attachment 560882 [details] [diff] [review] [diff] [details] [review]: > ----------------------------------------------------------------- > > Hmm. So the fix to bug 668500 caused this to break? > > I noticed one interesting quirk on trunk with the testcases I wrote for bug > 613749 (which implemented the support for limiting the prompt's size)... > With the "Wordy" and "XtraWordy" testcases the line breaks -- once -- and > the prompt overflows at small enough window sizes. [And snaps to the correct > size as soon as you resize the window.] But even with a super-narrow window, > the line only breaks once. I'm not sure I understand why it fails that way, > do you? This is due to the 60% width cap in the onResize method. What's 100% depends on the unwrapped string.
Assignee | ||
Updated•13 years ago
|
Attachment #560882 -
Flags: approval-mozilla-beta?
Attachment #560882 -
Flags: approval-mozilla-aurora?
Comment 19•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c2931c64df06
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
Comment 20•13 years ago
|
||
Comment on attachment 560882 [details] [diff] [review] patch release drivers are concerned about taking this into Beta. It's shipped as a regression in 7 and we're not seeing feedback that major sites or intranets are broken by this. absent that feedback, it's hard to justify taking this into Beta.
Attachment #560882 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 21•13 years ago
|
||
http://hg.mozilla.org/releases/mozilla-aurora/rev/550b6bcf09b3
word-wrap:break-word might have been useful here.
Comment 23•13 years ago
|
||
Comment on attachment 560882 [details] [diff] [review] patch Denied for beta.
Attachment #560882 -
Flags: approval-mozilla-beta? → approval-mozilla-beta-
Comment 24•13 years ago
|
||
Mozilla/5.0 (Windows NT 6.1; rv:9.0) Gecko/20100101 Firefox/9.0 Mozilla/5.0 (Windows NT 6.1; rv:10.0a2) Gecko/20111116 Firefox/10.0a2 Mozilla/5.0 (Windows NT 6.1; rv:11.0a1) Gecko/20111116 Firefox/11.0a1 Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:9.0) Gecko/20100101 Firefox/9.0 Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:10.0a2) Gecko/20111116 Firefox/10.0a2 Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:11.0a1) Gecko/20111117 Firefox/11.0a1 Mozilla/5.0 (Windows NT 5.1; rv:9.0) Gecko/20100101 Firefox/9.0 Mozilla/5.0 (Windows NT 5.1; rv:10.0a2) Gecko/20111110 Firefox/10.0a2 Mozilla/5.0 (Windows NT 5.1; rv:11.0a1) Gecko/20111110 Firefox/11.0a1 Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20100101 Firefox/9.0 Mozilla/5.0 (X11; Linux x86_64; rv:10.0a2) Gecko/20111117 Firefox/10.0a2 Mozilla/5.0 (X11; Linux x86_64; rv:11.0a1) Gecko/20111117 Firefox/11.0a1 Verified using teh testcase from comment #1 and no overlap was observed
Status: RESOLVED → VERIFIED
Keywords: verified-aurora,
verified-beta
You need to log in
before you can comment on or make changes to this bug.
Description
•