"Almost stacked" group might switch between stacked and unstacked display

VERIFIED FIXED in Firefox 9

Status

defect
VERIFIED FIXED
8 years ago
3 years ago

People

(Reporter: andreasjunghw, Assigned: raymondlee)

Tracking

({regression})

Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

Steps to reproduce:
1) Create a (new) tab group with two tabs in it.
2) Switch to Panorama and resize the group to be as small as possible without
   causing the tab group to switch to stacked view.
   => The group contains two tabs and is not stacked
3) Leave Panorama and create a third tab in this group.
4) Close the third tab again and switch back to Panorama.
   => The group contains two tabs and is stacked
5) Click the expand button and dismiss the expanded view.
   => The group is not stacked again

Since this sounds complicated I will attach a screencast.
Mozilla/5.0 (X11; Linux x86_64; rv:9.0a1) Gecko/20110913 Firefox/9.0a1
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:9.0a1) Gecko/20110913 Firefox/9.0a1
Mozilla/5.0 (Windows NT 6.1; rv:9.0a1) Gecko/20110913 Firefox/9.0a1

Reproduced using the steps in the description.

Regression range (the two tabs getting stacked(step 4)):

Last good nightly: 2011-08-09
First bad nightly: 2011-08-10

Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=87e3ea12ed5d&tochange=04dfb49d3a3d

The result from step 5 seems to enter in a separate range. Willing to search if necessary.
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows XP → All
Hardware: x86 → All
Whiteboard: regression
Version: unspecified → Trunk
Posted patch v1 (obsolete) — Splinter Review
The regression is caused by this change set
http://hg.mozilla.org/mozilla-central/rev/248aed2b337d

We shouldn't check the this.isStacked() in GroupItem_getContentBounds() because GroupItem_shouldStack() uses GroupItem_getContentBounds() which expects it to return the content bounds for non-stacked group.
Assignee: nobody → raymond
Status: NEW → ASSIGNED
Attachment #561400 - Flags: review?(dietrich)
Comment on attachment 561400 [details] [diff] [review]
v1

Review of attachment 561400 [details] [diff] [review]:
-----------------------------------------------------------------

code changes look fine. looking at the STR, this should be testable. can you add a test?
Attachment #561400 - Flags: review?(dietrich)
Posted patch v2 (obsolete) — Splinter Review
With test
Attachment #561400 - Attachment is obsolete: true
Attachment #561689 - Flags: review?(dietrich)
Comment on attachment 561689 [details] [diff] [review]
v2

Review of attachment 561689 [details] [diff] [review]:
-----------------------------------------------------------------

looks good, thanks!
Attachment #561689 - Flags: review?(dietrich) → review+
Push to try and waiting for the results
https://tbpl.mozilla.org/?tree=Try&rev=53f3f5aeddd2
Attachment #561689 - Attachment is obsolete: true
(In reply to Raymond Lee [:raymondlee] from comment #6)
> Created attachment 561952 [details] [diff] [review] [diff] [details] [review]
> Patch for checkin
> 
> Push to try and waiting for the results
> https://tbpl.mozilla.org/?tree=Try&rev=53f3f5aeddd2

Passed Try
Keywords: checkin-needed
Keywords: regression
Whiteboard: regression
Thanks for the nicely formatted patch + try run URL, makes pushing much easier :-)

https://hg.mozilla.org/integration/mozilla-inbound/rev/35e3a5f3c07b
Flags: in-testsuite+
Keywords: checkin-needed
Target Milestone: --- → Firefox 9
https://hg.mozilla.org/mozilla-central/rev/35e3a5f3c07b
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Mozilla/5.0 (X11; Linux x86_64; rv:9.0a1) Gecko/20110925 Firefox/9.0a1

Verified on Ubuntu 11.04, Windows XP, 7 and Mac OS 10.6 using the steps in the description. Tab group is no longer stacked as in step 4.
Status: RESOLVED → VERIFIED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.