Closed
Bug 686720
Opened 13 years ago
Closed 13 years ago
Expose /proc/smaps PSS in about:memory
Categories
(Toolkit :: about:memory, defect)
Tracking
()
RESOLVED
FIXED
mozilla9
People
(Reporter: justin.lebar+bug, Assigned: justin.lebar+bug)
References
Details
Attachments
(1 file)
5.90 KB,
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
For each mapping, smaps gives us an RSS and additionally a "proportional set size" (PSS). A page's PSS is its RSS divided by the number of processes which have that page mapped. I'd originally hidden PSS in about:memory, since on desktop, it's different from RSS only for shared libraries. It's not so interesting. But on mobile, PSS is much more interesting, because it shows us how much memory we're sharing between the content and chrome processes. So I think we should just show PSS; it'll be collapsed by default anyway.
Assignee | ||
Comment 1•13 years ago
|
||
See http://lxr.linux.no/#linux+v3.0.4/fs/proc/task_mmu.c#L344
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → justin.lebar+bug
Assignee | ||
Comment 2•13 years ago
|
||
Attachment #560412 -
Flags: review?(khuey)
Comment on attachment 560412 [details] [diff] [review] Patch v1 This looks fine, but it looks like the original that you made the diff against was weird ...
Attachment #560412 -
Flags: review?(khuey) → review+
Assignee | ||
Comment 4•13 years ago
|
||
Yeah, it looks like I somehow managed to include hunks from another patch in here. I'll figure it out before I push. Thanks.
Comment 5•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/bbf7bdb0c75f
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
You need to log in
before you can comment on or make changes to this bug.
Description
•