Closed Bug 686740 Opened 9 years ago Closed 9 years ago

Port Bug 686366 |Canceling Sign In wizard page triggers "Weave is not defined" error|

Categories

(SeaMonkey :: Sync UI, defect)

defect
Not set
minor

Tracking

(seamonkey2.3 wontfix, seamonkey2.4 wontfix, seamonkey2.5 wontfix, seamonkey2.6 fixed)

RESOLVED FIXED
seamonkey2.6
Tracking Status
seamonkey2.3 --- wontfix
seamonkey2.4 --- wontfix
seamonkey2.5 --- wontfix
seamonkey2.6 --- fixed

People

(Reporter: InvisibleSmiley, Assigned: InvisibleSmiley)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #686366 +++

Error: Weave is not defined
Source File: chrome://browser/content/syncSetup.js
Line: 621

STR:
1. Set Up Sync
2. Connect
3. I don't have the device with me
4. Cancel

Reasons:
1. Weave object not available in the context anymore
2. Wrong condition checked for dialog cancel

FF checkin:
http://hg.mozilla.org/services/services-central/rev/eef657744227
(forgot a dot at the end of the comment over there, added here)
Attachment #560220 - Flags: review?(neil)
Comment on attachment 560220 [details] [diff] [review]
patch [Checkin: comment 2]

I'm surprised that it's only Weave that isn't defined (in other words, I didn't see any of the other errors that can crop up when dealing with closed windows.)
Attachment #560220 - Flags: review?(neil) → review+
Comment on attachment 560220 [details] [diff] [review]
patch [Checkin: comment 2]

http://hg.mozilla.org/comm-central/rev/c7c95973f6a5
Attachment #560220 - Attachment description: patch → patch [Checkin: comment 2]
I think this is not important enough to warrant back-porting, so wontfixing anything but trunk.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.6
You need to log in before you can comment on or make changes to this bug.