The default bug view has changed. See this FAQ.

Web console: Move close button to the left on Mac

RESOLVED FIXED in Firefox 9

Status

()

Firefox
Developer Tools
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jaws, Assigned: jaws)

Tracking

unspecified
Firefox 9
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(2 attachments, 1 obsolete attachment)

Created attachment 560252 [details] [diff] [review]
Patch for bug

Bug 684561 moved the close button to the right on Windows but accidentally moved the close button to the right on Mac as well. Also some toolbarbutton margins that were increased on winstripe are also needed on gnomestripe.
Attachment #560252 - Flags: review?(dcamp)
Assignee: nobody → jwein
Status: NEW → ASSIGNED

Updated

6 years ago
Attachment #560252 - Flags: review?(dcamp)
Attachment #560252 - Flags: review?(dao)
Attachment #560252 - Flags: review+
Created attachment 560404 [details]
pre-patch screenshot

Here's what the buttons look like for me on Linux without this patch. This looks ok to me, I don't think more space around them is needed.
Created attachment 560825 [details] [diff] [review]
Patch for bug 686778 v2

Removed the style changes for gnomestripe since it wasn't too terrible looking on gnomestripe pre-patch.

HUDService.jsm was r+ from dcamp whereas webconsole.css review was forwarded to dao. Therefore, I'll carry forward r+ from dcamp.
Attachment #560252 - Attachment is obsolete: true
Attachment #560252 - Flags: review?(dao)
Attachment #560825 - Flags: review+
Summary: Web console: Move close button to the left on Mac and carry over style changes from Windows to Linux → Web console: Move close button to the left on Mac
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/4866693ce45c
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 9
You need to log in before you can comment on or make changes to this bug.