Undeclared variable causes the tab key navigation to stop working

RESOLVED FIXED in Firefox 9

Status

Firefox Graveyard
Panorama
RESOLVED FIXED
6 years ago
a year ago

People

(Reporter: raymondlee, Assigned: raymondlee)

Tracking

Trunk
Firefox 9

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Error: assignment to undeclared variable newIndex
Source File: chrome://browser/content/tabview.js
Line: 9160
(Assignee)

Comment 1

6 years ago
Created attachment 560324 [details] [diff] [review]
v1

Trivial patch
Attachment #560324 - Flags: review?(dietrich)
Comment on attachment 560324 [details] [diff] [review]
v1

Review of attachment 560324 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, thanks Raymond!
Attachment #560324 - Flags: review?(dietrich) → review+
(Assignee)

Comment 3

6 years ago
Created attachment 560500 [details] [diff] [review]
Patch for checkin

Push to try and waiting for results
https://tbpl.mozilla.org/?tree=Try&rev=504c8be84ecf
Attachment #560324 - Attachment is obsolete: true
(Assignee)

Updated

6 years ago
Attachment #560500 - Attachment is patch: true
(Assignee)

Comment 4

6 years ago
(In reply to Raymond Lee [:raymondlee] from comment #3)
> Push to try and waiting for results
> https://tbpl.mozilla.org/?tree=Try&rev=504c8be84ecf

Passed Try!
Keywords: checkin-needed

Comment 5

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/211b953c56fd
Keywords: checkin-needed
Target Milestone: --- → Firefox 9

Comment 6

6 years ago
https://hg.mozilla.org/mozilla-central/rev/211b953c56fd
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.