Last Comment Bug 686855 - Undeclared variable causes the tab key navigation to stop working
: Undeclared variable causes the tab key navigation to stop working
Status: RESOLVED FIXED
:
Product: Firefox Graveyard
Classification: Graveyard
Component: Panorama (show other bugs)
: Trunk
: All All
: -- normal
: Firefox 9
Assigned To: Raymond Lee [:raymondlee]
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-09-15 02:09 PDT by Raymond Lee [:raymondlee]
Modified: 2016-04-12 14:00 PDT (History)
1 user (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
v1 (897 bytes, patch)
2011-09-15 02:17 PDT, Raymond Lee [:raymondlee]
dietrich: review+
Details | Diff | Splinter Review
Patch for checkin (1.15 KB, patch)
2011-09-15 19:26 PDT, Raymond Lee [:raymondlee]
no flags Details | Diff | Splinter Review

Description Raymond Lee [:raymondlee] 2011-09-15 02:09:08 PDT
Error: assignment to undeclared variable newIndex
Source File: chrome://browser/content/tabview.js
Line: 9160
Comment 1 Raymond Lee [:raymondlee] 2011-09-15 02:17:41 PDT
Created attachment 560324 [details] [diff] [review]
v1

Trivial patch
Comment 2 Dietrich Ayala (:dietrich) 2011-09-15 10:44:32 PDT
Comment on attachment 560324 [details] [diff] [review]
v1

Review of attachment 560324 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, thanks Raymond!
Comment 3 Raymond Lee [:raymondlee] 2011-09-15 19:26:17 PDT
Created attachment 560500 [details] [diff] [review]
Patch for checkin

Push to try and waiting for results
https://tbpl.mozilla.org/?tree=Try&rev=504c8be84ecf
Comment 4 Raymond Lee [:raymondlee] 2011-09-16 02:37:46 PDT
(In reply to Raymond Lee [:raymondlee] from comment #3)
> Push to try and waiting for results
> https://tbpl.mozilla.org/?tree=Try&rev=504c8be84ecf

Passed Try!
Comment 6 Ed Morley [:emorley] 2011-09-17 02:05:55 PDT
https://hg.mozilla.org/mozilla-central/rev/211b953c56fd

Note You need to log in before you can comment on or make changes to this bug.