Move libraries at the top level in the apk

RESOLVED FIXED in mozilla9

Status

()

Core
Widget: Android
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

Trunk
mozilla9
ARM
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
I don't think there still are reasons to keep libraries under lib/ in the apk. And it would make my planned changes to the linker easier if they weren't.
(Assignee)

Comment 1

6 years ago
Created attachment 560342 [details] [diff] [review]
Move libraries at the top level in the apk
Assignee: nobody → mh+mozilla
Attachment #560342 - Flags: review?(mark.finkle)
Hmm, I can't recall why we used lib/ in the first place. Vlad and BLassey might know. Mike, do you know why we did it?
(Assignee)

Comment 3

6 years ago
Really none, apparently. The libs were all in lib/armeabi when we didn't have the custom linker. Then bug 588607 changed it so that only libmozutils is there, and other libs are in lib/. But I don't see a specific reason for their location to be lib/.
(Assignee)

Comment 4

6 years ago
Created attachment 561312 [details] [diff] [review]
Move libraries at the top level in the apk
Attachment #561312 - Flags: review?(mark.finkle)
(Assignee)

Updated

6 years ago
Attachment #560342 - Attachment is obsolete: true
Attachment #560342 - Flags: review?(mark.finkle)
Comment on attachment 561312 [details] [diff] [review]
Move libraries at the top level in the apk


>diff --git a/toolkit/mozapps/installer/packager.mk b/toolkit/mozapps/installer/packager.mk

>@@ -265,16 +265,30 @@ DIST_FILES = \

>   lib \

Is anything left in the lib folder?


Let's do it and see what shakes lose. Patch looks good.
Attachment #561312 - Flags: review?(mark.finkle) → review+
(Assignee)

Comment 6

6 years ago
(In reply to Mark Finkle (:mfinkle) from comment #5)
> Is anything left in the lib folder?

libmozutils.so, which is in lib/armeabi-v7a.
(Assignee)

Comment 7

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/50115be8eaf0
Whiteboard: [inbound]

Comment 8

6 years ago
https://hg.mozilla.org/mozilla-central/rev/50115be8eaf0
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla9
You need to log in before you can comment on or make changes to this bug.