Last Comment Bug 686876 - Move libraries at the top level in the apk
: Move libraries at the top level in the apk
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Widget: Android (show other bugs)
: Trunk
: ARM Android
: -- normal (vote)
: mozilla9
Assigned To: Mike Hommey [:glandium]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-09-15 07:58 PDT by Mike Hommey [:glandium]
Modified: 2011-09-21 18:16 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Move libraries at the top level in the apk (7.56 KB, patch)
2011-09-15 08:03 PDT, Mike Hommey [:glandium]
no flags Details | Diff | Splinter Review
Move libraries at the top level in the apk (7.57 KB, patch)
2011-09-20 15:17 PDT, Mike Hommey [:glandium]
mark.finkle: review+
Details | Diff | Splinter Review

Description Mike Hommey [:glandium] 2011-09-15 07:58:48 PDT
I don't think there still are reasons to keep libraries under lib/ in the apk. And it would make my planned changes to the linker easier if they weren't.
Comment 1 Mike Hommey [:glandium] 2011-09-15 08:03:13 PDT
Created attachment 560342 [details] [diff] [review]
Move libraries at the top level in the apk
Comment 2 Mark Finkle (:mfinkle) (use needinfo?) 2011-09-18 19:22:59 PDT
Hmm, I can't recall why we used lib/ in the first place. Vlad and BLassey might know. Mike, do you know why we did it?
Comment 3 Mike Hommey [:glandium] 2011-09-18 23:21:27 PDT
Really none, apparently. The libs were all in lib/armeabi when we didn't have the custom linker. Then bug 588607 changed it so that only libmozutils is there, and other libs are in lib/. But I don't see a specific reason for their location to be lib/.
Comment 4 Mike Hommey [:glandium] 2011-09-20 15:17:37 PDT
Created attachment 561312 [details] [diff] [review]
Move libraries at the top level in the apk
Comment 5 Mark Finkle (:mfinkle) (use needinfo?) 2011-09-20 19:11:48 PDT
Comment on attachment 561312 [details] [diff] [review]
Move libraries at the top level in the apk


>diff --git a/toolkit/mozapps/installer/packager.mk b/toolkit/mozapps/installer/packager.mk

>@@ -265,16 +265,30 @@ DIST_FILES = \

>   lib \

Is anything left in the lib folder?


Let's do it and see what shakes lose. Patch looks good.
Comment 6 Mike Hommey [:glandium] 2011-09-20 22:17:11 PDT
(In reply to Mark Finkle (:mfinkle) from comment #5)
> Is anything left in the lib folder?

libmozutils.so, which is in lib/armeabi-v7a.
Comment 8 Ed Morley [:emorley] 2011-09-21 18:16:04 PDT
https://hg.mozilla.org/mozilla-central/rev/50115be8eaf0

Note You need to log in before you can comment on or make changes to this bug.