686896 - Properly escape keyword searches when alternative character sets are specified.

Status: RESOLVED FIXED

(SeaMonkey :: Location Bar, defect)

Description

[Philip Chee]

From Firefox Bug 359809: Bookmark Keyword searches are not encoded properly (though keyword.URL is)

> Quick Search does not URL-encode plus signs (+). 
> 
> Searching for "c++" (without quotes), the %s (replaced portion of the URL) appears in the URL as:
> c++
> Instead of:
> c%2B%2B
> 
> The encoding (++) being decoded by the server as two spaces. 
> 
> 
> Reproducible: Always
> 
> Steps to Reproduce:
> 1) Create a bookmark with the address:
> http://www.google.com.au/search?hl=en&q=%s&btnG=Google+Search&meta=
> 
> 2) Assign a keyword to the bookmark, i.e: 'g' (without quotes). 
> 
> 3) Type "g c++" (without quotes) in the address bar and press Enter. 
> 
> Actual Results:  
> The plus signs (+) do not get URL-encoded. 
> 
> Expected Results:  
> + should be encoded as %2B

Comment 1

[Philip Chee]

Attachment: Patch v1.0.

Fixit.

Comment 2

[[e-mail]]

Comment on attachment 560376 [details] [diff] [review]
Patch v1.0.

>+    // escape() works in those cases, but it doesn't uri-encode +, @, and /.
[Wonder why they didn't list them in ASCII order...]

Comment 3

[Philip Chee]

Pushed to comm-central
http://hg.mozilla.org/comm-central/rev/3a0e7fdf8b1c