686941 - Consider making nsIDocument::mCachedRootElement a weak pointer

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Seems like that would allow us to make it an Element*.

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

This makes us store an Element*, at the cost of moving the function into nsDocument.cpp.  If that's not acceptable I can go back to the nsIContent*.

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Back to an nsINode of course.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 560776 [details] [diff] [review]
Patch

>@@ -1918,17 +1917,16 @@ NS_IMPL_CYCLE_COLLECTION_UNLINK_BEGIN(ns
>   for (PRInt32 indx = PRInt32(tmp->mChildren.ChildCount()) - 1; 
>        indx >= 0; --indx) {
>     tmp->mChildren.ChildAt(indx)->UnbindFromTree();
>     tmp->mChildren.RemoveChildAt(indx);
>   }
>   tmp->mFirstChild = nsnull;
> 
>   NS_IMPL_CYCLE_COLLECTION_UNLINK_NSCOMPTR(mXPathEvaluatorTearoff)
>-  NS_IMPL_CYCLE_COLLECTION_UNLINK_NSCOMPTR(mCachedRootElement)
You must add tmp->mCachedRootElement = nsnull;
otherwise it may point to a deleted object after unlinking.

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/mozilla-central/rev/d0dac9811895