Closed Bug 687037 Opened 8 years ago Closed 8 years ago

Typo in GNOME colorpicker.css

Categories

(Toolkit :: Themes, defect)

x86
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla9

People

(Reporter: gk, Assigned: t.matsuu)

References

Details

(Whiteboard: [good first bug])

Attachments

(1 file)

User Agent: Mozilla/5.0 (X11; Linux i686; rv:9.0a1) Gecko/20110915 Firefox/9.0a1
Build ID: 20110915030845

Steps to reproduce:

I have included a colorpicker in my add-on in order to let the user choose the color for a proxy.


Actual results:

Opening the dialog containing the colorpicker gives me a 

Warning: Expected declaration but found '+'.  Skipped to next declaration.
Source File: chrome://global/skin/colorpicker.css
Line: 72

on my Ubuntu 10.04 using a nightly build of Firefox.


Expected results:

There should be not such a warning. If one compares

http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/pinstripe/global/colorpicker.css
http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/winstripe/global/colorpicker.css
http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/gnomestripe/global/colorpicker.css

it seems the "+" is just a typo in the GNOME version of the CSS file.
Blocks: 655691
Status: UNCONFIRMED → NEW
Component: XUL → Themes
Ever confirmed: true
Product: Core → Toolkit
QA Contact: xptoolkit.widgets → themes
Version: unspecified → Trunk
Whiteboard: [good first bug]
Attached patch fix typoSplinter Review
This patch may fix this bug.
Attachment #560789 - Flags: review?(dao)
Attachment #560789 - Flags: review?(dao) → review+
Assignee: nobody → t.matsuu
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/52c42cbf25fb
Status: NEW → ASSIGNED
Flags: in-testsuite-
Keywords: checkin-needed
Target Milestone: --- → mozilla9
https://hg.mozilla.org/mozilla-central/rev/52c42cbf25fb
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.