Add Telemetry for hit rate & revalidation rate per cache type

RESOLVED FIXED in mozilla10

Status

()

Core
Networking: Cache
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: nwgh, Assigned: nwgh)

Tracking

unspecified
mozilla10
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

+++ This bug was initially created as a clone of Bug #686948 +++

We want to collect telemetry for the following bits of information (for each of memory/disk/offline cache in this case):

Cache hit (without revalidation from the server)
Successful revalidation (hit with network overhead)
Failed revalidation (we have an entry but after asking the server it can no longer be used)
Cache miss (no entry in the cache)

Updated

6 years ago
Assignee: nobody → gbrown
To clarify, do we want something like:

-HISTOGRAM(HTTP_CACHE_DISPOSITION, 1, 5, 5, LINEAR, "HTTP Cache Hit, Reval, Failed-Reval, Miss")

+HISTOGRAM(HTTP_DISK_CACHE_DISPOSITION, 1, 5, 5, LINEAR, "HTTP Cache Hit, Reval, Failed-Reval, Miss")
+HISTOGRAM(HTTP_MEMORY_CACHE_DISPOSITION, 1, 5, 5, LINEAR, "HTTP Cache Hit, Reval, Failed-Reval, Miss")
+HISTOGRAM(HTTP_OFFLINE_CACHE_DISPOSITION, 1, 5, 5, LINEAR, "HTTP Cache Hit, Reval, Failed-Reval, Miss")

?
My intention was to keep the original HTTP_CACHE_DISPOSITION telemetry, and add in the other 3.

I was actually working on this one this morning (don't know why I hadn't assigned it to myself, but you doing it is fine) and got to thinking that having a "pure miss" count by device type may not work anyway (since we wouldn't have a cache entry to figure out what cache device to mark), unless we wanted to count it as a miss on all device types (which while technically correct, may end up skewing our view of things). So perhaps we should just do hit/reval/failed-reval for the device-specific bins? I'm open to suggestions.
Reassigning after discussion w/Geoff
Assignee: gbrown → hurley
Created attachment 563834 [details] [diff] [review]
patch

Extends the work we already did for general disposition, and adds device-specific counts.
Attachment #563834 - Flags: review?(mcmanus)
Attachment #563834 - Flags: review?(mcmanus) → review+
https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&rev=cc8d1fd89bac
It seems to me as if try is fine (still new at figuring this all out...)
Keywords: checkin-needed
http://hg.mozilla.org/integration/mozilla-inbound/rev/a516cf2d48f6
Keywords: checkin-needed
Target Milestone: --- → mozilla10

Comment 8

6 years ago
https://hg.mozilla.org/mozilla-central/rev/a516cf2d48f6
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Depends on: 736844
You need to log in before you can comment on or make changes to this bug.