GCC 4.6 build warning: "js/src/xpconnect/shell/xpcshell.cpp:549: warning: variable 'preBytes' set but not used [-Wunused-but-set-variable]"

RESOLVED FIXED in mozilla10

Status

()

Core
XPConnect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: froydnj, Assigned: froydnj)

Tracking

(Blocks: 1 bug)

Trunk
mozilla10
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [build_warning])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
The `preBytes' variable in xpcshell.cpp:GC is set but not used.  Patch coming up.
(Assignee)

Comment 1

6 years ago
Created attachment 560591 [details] [diff] [review]
patch to remove preBytes
Attachment #560591 - Flags: review?(jorendorff)

Updated

6 years ago
Assignee: nobody → nfroyd

Updated

6 years ago
Blocks: 187528

Updated

6 years ago
Whiteboard: [build_warning]
Comment on attachment 560591 [details] [diff] [review]
patch to remove preBytes

OK.
Attachment #560591 - Flags: review?(jorendorff) → review+
(Assignee)

Comment 3

6 years ago
Comment on attachment 560591 [details] [diff] [review]
patch to remove preBytes

Tweak name of patch.
Attachment #560591 - Attachment description: patch to removed preBytes → patch to remove preBytes
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
(Assignee)

Comment 4

6 years ago
Created attachment 565248 [details] [diff] [review]
patch to remove preBytes

Updated patch with proper commit message.
Attachment #560591 - Attachment is obsolete: true
Attachment #565248 - Flags: review+

Comment 5

6 years ago
In my queue, which is heading to try first then inbound :-)
https://tbpl.mozilla.org/?tree=Try&rev=a8fbb2a76633
Keywords: checkin-needed
OS: Linux → All
Hardware: x86 → All

Comment 6

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/69ae30e1bc3e
Status: NEW → ASSIGNED
Flags: in-testsuite-
Target Milestone: --- → mozilla10
Version: unspecified → Trunk
https://hg.mozilla.org/mozilla-central/rev/69ae30e1bc3e
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.