Last Comment Bug 687121 - GCC 4.6 build warning: "js/src/xpconnect/shell/xpcshell.cpp:549: warning: variable 'preBytes' set but not used [-Wunused-but-set-variable]"
: GCC 4.6 build warning: "js/src/xpconnect/shell/xpcshell.cpp:549: warning: var...
Status: RESOLVED FIXED
[build_warning]
:
Product: Core
Classification: Components
Component: XPConnect (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla10
Assigned To: Nathan Froyd [:froydnj]
:
Mentors:
Depends on:
Blocks: buildwarning
  Show dependency treegraph
 
Reported: 2011-09-16 11:07 PDT by Nathan Froyd [:froydnj]
Modified: 2011-10-07 12:37 PDT (History)
3 users (show)
emorley: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch to remove preBytes (724 bytes, patch)
2011-09-16 11:10 PDT, Nathan Froyd [:froydnj]
jorendorff: review+
Details | Diff | Review
patch to remove preBytes (849 bytes, patch)
2011-10-06 08:55 PDT, Nathan Froyd [:froydnj]
nfroyd: review+
Details | Diff | Review

Description Nathan Froyd [:froydnj] 2011-09-16 11:07:18 PDT
The `preBytes' variable in xpcshell.cpp:GC is set but not used.  Patch coming up.
Comment 1 Nathan Froyd [:froydnj] 2011-09-16 11:10:38 PDT
Created attachment 560591 [details] [diff] [review]
patch to remove preBytes
Comment 2 Jason Orendorff [:jorendorff] 2011-10-05 07:16:04 PDT
Comment on attachment 560591 [details] [diff] [review]
patch to remove preBytes

OK.
Comment 3 Nathan Froyd [:froydnj] 2011-10-06 07:12:24 PDT
Comment on attachment 560591 [details] [diff] [review]
patch to remove preBytes

Tweak name of patch.
Comment 4 Nathan Froyd [:froydnj] 2011-10-06 08:55:43 PDT
Created attachment 565248 [details] [diff] [review]
patch to remove preBytes

Updated patch with proper commit message.
Comment 5 Ed Morley [:emorley] 2011-10-07 03:30:37 PDT
In my queue, which is heading to try first then inbound :-)
https://tbpl.mozilla.org/?tree=Try&rev=a8fbb2a76633
Comment 7 Matt Brubeck (:mbrubeck) 2011-10-07 12:37:58 PDT
https://hg.mozilla.org/mozilla-central/rev/69ae30e1bc3e

Note You need to log in before you can comment on or make changes to this bug.