Improve <meter> a11y by adding ticks showing 'low' and 'high' values

NEW
Assigned to

Status

()

Core
Layout: Form Controls
6 years ago
a year ago

People

(Reporter: mounir, Assigned: mounir)

Tracking

(Blocks: 1 bug, {access})

Trunk
access
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [needs review])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 560663 [details] [diff] [review]
Patch v1

To improve the visual a11y of the element, I have a patch that adds two ticks, one representing the low mark and one representing the high mark. If low==high, only one is draw and if low==min or, the low mark isn't draw. Same thing for high==max.
The idea is with low and high marks, the user will be able to see the limits. Where the value has to be might be understandable from the contexts: if the meter represents the number of bugs in Firefox, it will have to be low, if it represents the number of Firefox users, it will have to be high.

This patch should be nearly ready. I might have to do a bit of clean-up. Nothing important.

David, how does it sound?
Attachment #560663 - Flags: review?(roc)
Attachment #560663 - Flags: feedback?(bolterbugz)
(Assignee)

Updated

6 years ago
Whiteboard: [needs review]
Comment on attachment 560663 [details] [diff] [review]
Patch v1

Review of attachment 560663 [details] [diff] [review]:
-----------------------------------------------------------------

Seems to me that this could paint outside the content-box or even the border-box of the meter. In that case, your nsMeterFrame::Reflow needs to add the relevant overflow area before calling FinishAndStoreOverflow --- definitely to the visual overflow area, and possibly to the scrollable overflow area, if you want to be able to scroll to see these marks. Your display item's GetBounds needs to include the overflow area too (possibly just by returning the frame's overflow area).

::: layout/forms/nsMeterFrame.cpp
@@ +302,5 @@
> +class LimitsPainter {
> +public:
> +  static void
> +  PaintLimit(nsRenderingContext* aCtx, const nsRect& aRect, float aValue,
> +             bool aIsHorizontal, bool aIsRTL)

probably a little cleaner to pass the orientation and direction directly and test for values in the body of this method. boolean parameters aren't good.

@@ +307,5 @@
> +  {
> +    // Points come from the coordinates on a 5X4 unit box.
> +    static const PRInt32 arrowPolygonX[] = { -2,  2, 0 };
> +    static const PRInt32 arrowPolygonY[] = { -4, -4, 0 };
> +    static const PRInt32 arrowNumPoints = sizeof(arrowPolygonX) / sizeof(PRInt32);

use NS_ARRAY_LENGTH

@@ +330,5 @@
> +      } else if (!aIsRTL) {
> +        paintPolygon[i] = nsPoint(x + nsPresContext::CSSPixelsToAppUnits(arrowPolygonY[i]),
> +                                  y + nsPresContext::CSSPixelsToAppUnits(arrowPolygonX[i]));
> +      } else {
> +        paintPolygon[i] = nsPoint(x + nsPresContext::CSSPixelsToAppUnits(abs(arrowPolygonY[i])),

Why not x - nsPresContext::CSSPixelsToAppUnits(arrowPolygonY[i])?

@@ +341,5 @@
> +  static void
> +  Paint(nsIFrame* aFrame,
> +        nsRenderingContext* aCtx,
> +        const nsRect& aDirtyRect,
> +        nsPoint aPt)

Probably simpler just to make Paint() and PaintLimit() static global functions.

Updated

6 years ago
Attachment #560663 - Flags: feedback?(bolterbugz) → feedback+

Updated

6 years ago
Keywords: access
Attachment #560663 - Flags: review?(roc)
You need to log in before you can comment on or make changes to this bug.