Misc mozconfig detection code improvements

RESOLVED FIXED in mozilla10

Status

()

Core
Build Config
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: sid0, Assigned: sid0)

Tracking

unspecified
mozilla10
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-bs)

Attachments

(1 attachment, 1 obsolete attachment)

Created attachment 560724 [details] [diff] [review]
patch

Neil pointed out two possible minor improvements that could be made to our new mozconfig detection code:
- echo `abspath $_config` is an unnecessary roundtrip from pipe to string then back.
- the "Adding configure options" and "Adding client.mk options" texts should be changed to use FOUND_MOZCONFIG rather than MOZCONFIG.
Attachment #560724 - Flags: review?(ted.mielczarek)
Attachment #560724 - Flags: feedback?(neil)
(Assignee)

Comment 1

6 years ago
Created attachment 560725 [details] [diff] [review]
patch

sorry, uploaded an incorrect version of the patch.
Attachment #560724 - Attachment is obsolete: true
Attachment #560724 - Flags: review?(ted.mielczarek)
Attachment #560724 - Flags: feedback?(neil)
Attachment #560725 - Flags: review?(ted.mielczarek)
Attachment #560725 - Flags: feedback?(neil)

Comment 2

6 years ago
Comment on attachment 560725 [details] [diff] [review]
patch

(What about the :+ ?)
Attachment #560725 - Flags: feedback?(neil) → feedback+
(Assignee)

Comment 3

6 years ago
(In reply to neil@parkwaycc.co.uk from comment #2)
> Comment on attachment 560725 [details] [diff] [review]
> patch
> 
> (What about the :+ ?)

I explained why it should be + in bug 681659 comment 6.
Attachment #560725 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 4

6 years ago
https://hg.mozilla.org/projects/build-system/rev/97beb3824d47
Whiteboard: fixed-in-bs
https://hg.mozilla.org/mozilla-central/rev/97beb3824d47
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
(Assignee)

Comment 6

6 years ago
Pushed to comm-central too. http://hg.mozilla.org/comm-central/rev/41c376e2297b
You need to log in before you can comment on or make changes to this bug.