Closed Bug 687275 Opened 13 years ago Closed 13 years ago

Misc mozconfig detection code improvements

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla10

People

(Reporter: rain1, Assigned: rain1)

Details

(Whiteboard: fixed-in-bs)

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
Neil pointed out two possible minor improvements that could be made to our new mozconfig detection code:
- echo `abspath $_config` is an unnecessary roundtrip from pipe to string then back.
- the "Adding configure options" and "Adding client.mk options" texts should be changed to use FOUND_MOZCONFIG rather than MOZCONFIG.
Attachment #560724 - Flags: review?(ted.mielczarek)
Attachment #560724 - Flags: feedback?(neil)
Attached patch patchSplinter Review
sorry, uploaded an incorrect version of the patch.
Attachment #560724 - Attachment is obsolete: true
Attachment #560724 - Flags: review?(ted.mielczarek)
Attachment #560724 - Flags: feedback?(neil)
Attachment #560725 - Flags: review?(ted.mielczarek)
Attachment #560725 - Flags: feedback?(neil)
Comment on attachment 560725 [details] [diff] [review]
patch

(What about the :+ ?)
Attachment #560725 - Flags: feedback?(neil) → feedback+
(In reply to neil@parkwaycc.co.uk from comment #2)
> Comment on attachment 560725 [details] [diff] [review]
> patch
> 
> (What about the :+ ?)

I explained why it should be + in bug 681659 comment 6.
Attachment #560725 - Flags: review?(ted.mielczarek) → review+
https://hg.mozilla.org/mozilla-central/rev/97beb3824d47
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.