687298 - Preference checkboxes re-toggling on tap

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Mozilla/5.0 (Android; Linux armv7l; rv:9.0a1) Gecko/20110917 Firefox/9.0a1 Fennec/9.0a1

Tapping a preference checkbox re-toggles it's state thus making no change.

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=39b192706927&tochange=85fb038d1dd1

Guessing a regression from either:
http://hg.mozilla.org/mozilla-central/rev/56a5de4a7413 
http://hg.mozilla.org/mozilla-central/rev/94182039abda

Comment 1

[Aaron Train [:aaronmt]]

For the record, this is when one taps directly on the checkbox.

Comment 2

[Matt Brubeck (:mbrubeck)]

Sorry, stealing this because I started working on a patch before I saw it was assigned.

Comment 3

[Matt Brubeck (:mbrubeck)]

Attachment: patch

Prevents the click event from reaching the checkbox.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 560937 [details] [diff] [review]
patch

stealing review

Comment 5

[Matt Brubeck (:mbrubeck)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/1db035c0e495

Comment 7

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/1db035c0e495

Comment 8

[Cristian Nicolae (:xti)]

Verified fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110921
Firefox/9.0a1 Fennec/9.0a1
Device: Samsung Galaxy S
OS: Android 2.2