Last Comment Bug 687340 - Make dynamic changes to mask, clipPath and marker attributes work
: Make dynamic changes to mask, clipPath and marker attributes work
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: SVG (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla9
Assigned To: Robert Longson
:
Mentors:
Depends on:
Blocks: 687445
  Show dependency treegraph
 
Reported: 2011-09-18 07:00 PDT by Robert Longson
Modified: 2011-09-20 04:22 PDT (History)
3 users (show)
longsonr: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (18.38 KB, patch)
2011-09-18 07:01 PDT, Robert Longson
roc: review+
Details | Diff | Review
what's left (14.75 KB, patch)
2011-09-19 05:56 PDT, Robert Longson
no flags Details | Diff | Review
what's left (13.10 KB, patch)
2011-09-19 05:58 PDT, Robert Longson
no flags Details | Diff | Review

Description Robert Longson 2011-09-18 07:00:47 PDT

    
Comment 1 Robert Longson 2011-09-18 07:01:29 PDT
Created attachment 560788 [details] [diff] [review]
patch
Comment 2 Robert Longson 2011-09-18 10:17:26 PDT
This also fixes bug 456323 so I'll reenable that test when this lands.
Comment 3 Robert O'Callahan (:roc) (Exited; email my personal email if necessary) 2011-09-18 16:43:45 PDT
Comment on attachment 560788 [details] [diff] [review]
patch

Review of attachment 560788 [details] [diff] [review]:
-----------------------------------------------------------------

The changes to nsSVGUtils could go in a separate patch too.

::: layout/svg/base/src/nsSVGMaskFrame.cpp
@@ +86,5 @@
>  
>    gfx->Save();
>    nsSVGUtils::SetClipRect(gfx, aMatrix, maskArea);
>    gfxRect clipExtents = gfx->GetClipExtents();
> +  clipExtents.RoundOut();

Can you put this change in a separate patch? It seems unrelated.
Comment 4 Robert O'Callahan (:roc) (Exited; email my personal email if necessary) 2011-09-18 16:44:04 PDT
(r+ from me on all three patches)
Comment 5 Robert Longson 2011-09-19 05:56:50 PDT
Created attachment 560881 [details] [diff] [review]
what's left
Comment 6 Robert Longson 2011-09-19 05:58:21 PDT
Created attachment 560884 [details] [diff] [review]
what's left
Comment 8 Ed Morley [:emorley] 2011-09-20 04:22:37 PDT
https://hg.mozilla.org/mozilla-central/rev/c6d4e5bce80b

Note You need to log in before you can comment on or make changes to this bug.