The default bug view has changed. See this FAQ.

Make dynamic changes to mask, clipPath and marker attributes work

RESOLVED FIXED in mozilla9

Status

()

Core
SVG
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Robert Longson, Assigned: Robert Longson)

Tracking

Trunk
mozilla9
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Comment hidden (empty)
(Assignee)

Comment 1

6 years ago
Created attachment 560788 [details] [diff] [review]
patch
Assignee: nobody → longsonr
Attachment #560788 - Flags: review?(roc)
(Assignee)

Comment 2

6 years ago
This also fixes bug 456323 so I'll reenable that test when this lands.
Blocks: 456323
Comment on attachment 560788 [details] [diff] [review]
patch

Review of attachment 560788 [details] [diff] [review]:
-----------------------------------------------------------------

The changes to nsSVGUtils could go in a separate patch too.

::: layout/svg/base/src/nsSVGMaskFrame.cpp
@@ +86,5 @@
>  
>    gfx->Save();
>    nsSVGUtils::SetClipRect(gfx, aMatrix, maskArea);
>    gfxRect clipExtents = gfx->GetClipExtents();
> +  clipExtents.RoundOut();

Can you put this change in a separate patch? It seems unrelated.
Attachment #560788 - Flags: review?(roc) → review+
(r+ from me on all three patches)
(Assignee)

Comment 5

6 years ago
Created attachment 560881 [details] [diff] [review]
what's left
Attachment #560788 - Attachment is obsolete: true
(Assignee)

Comment 6

6 years ago
Created attachment 560884 [details] [diff] [review]
what's left
Attachment #560881 - Attachment is obsolete: true
(Assignee)

Comment 7

6 years ago
pushed https://hg.mozilla.org/integration/mozilla-inbound/rev/c6d4e5bce80b
Flags: in-testsuite+
(Assignee)

Updated

6 years ago
Blocks: 687445
(Assignee)

Updated

6 years ago
No longer blocks: 456323
(Assignee)

Updated

6 years ago
Blocks: 687518
(Assignee)

Updated

6 years ago
No longer blocks: 687518
https://hg.mozilla.org/mozilla-central/rev/c6d4e5bce80b
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
You need to log in before you can comment on or make changes to this bug.