Closed Bug 687340 Opened 9 years ago Closed 9 years ago

Make dynamic changes to mask, clipPath and marker attributes work

Categories

(Core :: SVG, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla9

People

(Reporter: longsonr, Assigned: longsonr)

References

Details

Attachments

(1 file, 2 obsolete files)

No description provided.
Attached patch patch (obsolete) — Splinter Review
Assignee: nobody → longsonr
Attachment #560788 - Flags: review?(roc)
This also fixes bug 456323 so I'll reenable that test when this lands.
Blocks: 456323
Comment on attachment 560788 [details] [diff] [review]
patch

Review of attachment 560788 [details] [diff] [review]:
-----------------------------------------------------------------

The changes to nsSVGUtils could go in a separate patch too.

::: layout/svg/base/src/nsSVGMaskFrame.cpp
@@ +86,5 @@
>  
>    gfx->Save();
>    nsSVGUtils::SetClipRect(gfx, aMatrix, maskArea);
>    gfxRect clipExtents = gfx->GetClipExtents();
> +  clipExtents.RoundOut();

Can you put this change in a separate patch? It seems unrelated.
Attachment #560788 - Flags: review?(roc) → review+
(r+ from me on all three patches)
Attached patch what's left (obsolete) — Splinter Review
Attachment #560788 - Attachment is obsolete: true
Attached patch what's leftSplinter Review
Attachment #560881 - Attachment is obsolete: true
Blocks: 687445
No longer blocks: 456323
Blocks: 687518
No longer blocks: 687518
https://hg.mozilla.org/mozilla-central/rev/c6d4e5bce80b
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
You need to log in before you can comment on or make changes to this bug.