687340 - Make dynamic changes to mask, clipPath and marker attributes work

Status: RESOLVED FIXED

(Core :: SVG, defect)

Comment 1

[Robert Longson [:longsonr]]

Attachment: patch

Comment 2

[Robert Longson [:longsonr]]

This also fixes bug 456323 so I'll reenable that test when this lands.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 560788 [details] [diff] [review]
patch

Review of attachment 560788 [details] [diff] [review]:
-----------------------------------------------------------------

The changes to nsSVGUtils could go in a separate patch too.

::: layout/svg/base/src/nsSVGMaskFrame.cpp
@@ +86,5 @@
>  
>    gfx->Save();
>    nsSVGUtils::SetClipRect(gfx, aMatrix, maskArea);
>    gfxRect clipExtents = gfx->GetClipExtents();
> +  clipExtents.RoundOut();

Can you put this change in a separate patch? It seems unrelated.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

(r+ from me on all three patches)

Comment 5

[Robert Longson [:longsonr]]

Attachment: what's left

Comment 6

[Robert Longson [:longsonr]]

Attachment: what's left

Comment 7

[Robert Longson [:longsonr]]

pushed https://hg.mozilla.org/integration/mozilla-inbound/rev/c6d4e5bce80b

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/c6d4e5bce80b