Provide mozilla::layers::SurfaceDescriptorX11 non xlib surface ctor

RESOLVED FIXED in mozilla9

Status

()

Core
Graphics
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: romaxa, Assigned: romaxa)

Tracking

Trunk
mozilla9
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
I'm trying to make better transition from mozilla::plugins::SurfaceDescriptorX11 and mozilla::layers::SurfaceDescriptorX11

And in order to allow seamless conversion we need SurfaceDescriptorX11::SurfaceDescriptorX11(const int XID, const int xrenderPictID, const gfxIntSize& size)
ctor.
(Assignee)

Comment 1

6 years ago
Created attachment 560815 [details] [diff] [review]
Provide mozilla::layers::SurfaceDescriptorX11 non xlib surface ctor
Assignee: nobody → romaxa
Attachment #560815 - Flags: review?(jones.chris.g)
(Assignee)

Updated

6 years ago
Blocks: 598277
Comment on attachment 560815 [details] [diff] [review]
Provide mozilla::layers::SurfaceDescriptorX11 non xlib surface ctor

>+SurfaceDescriptorX11::SurfaceDescriptorX11(const int XID, const int xrenderPictID, const gfxIntSize& size)

(aXid, aXrenderPictId, aSize) plz.

>+  SurfaceDescriptorX11(const int XID, const int xrenderPictID, const gfxIntSize& size);
>+

And here.

r=me with nits fixed.
Attachment #560815 - Flags: review?(jones.chris.g) → review+
(Assignee)

Comment 3

6 years ago
Created attachment 561101 [details] [diff] [review]
Provide mozilla::layers::SurfaceDescriptorX11 non xlib surface ctor. TOPUSH

Fixed nits
Attachment #560815 - Attachment is obsolete: true
Attachment #561101 - Flags: review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed

Comment 4

6 years ago
This is now in my queue of things that are being sent to try then onto inbound :-)
Status: NEW → ASSIGNED
Keywords: checkin-needed

Comment 5

6 years ago
https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&rev=f07268905b26

https://hg.mozilla.org/integration/mozilla-inbound/rev/969aaa109a23
Target Milestone: --- → mozilla9
https://hg.mozilla.org/mozilla-central/rev/969aaa109a23
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.