Closed Bug 687380 Opened 8 years ago Closed 8 years ago

Do not generate NSPR pkg/linux/* and pkg/solaris/* Makefiles on platforms where they will not be used

Categories

(NSPR :: NSPR, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: emorley, Assigned: emorley)

Details

Attachments

(1 file, 2 obsolete files)

Building Firefox locally using MSVC 2010 with http://hg.mozilla.org/integration/mozilla-inbound/rev/f827e9173fea

Output from NSPR configure:
{
...
creating pkg/linux/Makefile
creating pkg/solaris/Makefile
creating pkg/solaris/SUNWpr/Makefile
creating pkg/solaris/SUNWprd/Makefile
...
}

/nsprpub/pkg/Makefile.in specifies the following:
{
ifeq ($(OS_TARGET),Linux)
DIRS = linux
endif
ifeq ($(OS_TARGET),SunOS)
DIRS = solaris
endif
}

So it would make sense to add something similar to configure:
http://mxr.mozilla.org/mozilla-central/source/nsprpub/configure.in#3322
Attached patch Patch v1 (obsolete) — Splinter Review
Adds the same platform ifdefs to the configure makefiles output generation for pkg/linux/* and pkg/solaris/* as those found in pkg/Makefile.in.

Note: The patch was based off of mozilla-inbound, but this is intended for upstream NSPR. I decided against figuring out how to use CVS until after it's clear whether the patch will be r+'d. 

Thanks :-)
Attachment #560829 - Flags: review?(ted.mielczarek)
Attached patch Patch v1.1 (obsolete) — Splinter Review
As above, but with brain engaged.
Attachment #560829 - Attachment is obsolete: true
Attachment #560829 - Flags: review?(ted.mielczarek)
Attachment #560830 - Flags: review?(ted.mielczarek)
Attachment #560830 - Flags: review?(ted.mielczarek) → review+
As previously r+'d, except:
* Is now a CVS diff.
* Removes the dnl lines since either dupes or else the makefiles to which they refer are NPOTB.
* Whitespace/wrapping/indentation improvements:
    -Removes trailing whitespace whilst I'm there
    -Splits the |MAKEFILES="$MAKEFILES foo/bar/Makefile"| entries onto 
     multiple lines for readability (also allows for easier parsing of 
     the generated makefiles for the script in bug 696498)
    -Adjusts indentation for readability (happy to take input on this 
     one, if you don't feel it's appropriate)

Presuming you're ok with the post r+ changes, can you land it for me please Ted :-)
Attachment #560830 - Attachment is obsolete: true
Checking in configure;
/cvsroot/mozilla/nsprpub/configure,v  <--  configure
new revision: 1.317; previous revision: 1.316
done
Checking in configure.in;
/cvsroot/mozilla/nsprpub/configure.in,v  <--  configure.in
new revision: 1.319; previous revision: 1.318
done
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.9
You need to log in before you can comment on or make changes to this bug.