Closed Bug 687389 Opened 8 years ago Closed 8 years ago

MSVC 2010 warning C4005: '_WIN32_WINNT' : macro redefinition for various files under accessible/public/*

Categories

(Core :: Disability Access APIs, defect)

x86
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla9

People

(Reporter: emorley, Assigned: emorley)

References

(Blocks 1 open bug)

Details

(Whiteboard: [build_warning])

Attachments

(1 file)

MSVC 2010 using http://hg.mozilla.org/integration/mozilla-inbound/rev/f827e9173fea

{
ISimpleDOMDocument_i.c
c:\mozilla\repos\obj-inbound\accessible\public\msaa\../../../dist/include/mozilla-config.h(91) : warning C4005: '_WIN32_WINNT' : macro redefinition
        command-line arguments :  see previous definition of '_WIN32_WINNT'
ISimpleDOMNode_i.c
c:\mozilla\repos\obj-inbound\accessible\public\msaa\../../../dist/include/mozilla-config.h(91) : warning C4005: '_WIN32_WINNT' : macro redefinition
        command-line arguments :  see previous definition of '_WIN32_WINNT'
...plus more under accessible/public/msaa/
}

{
Accessible2_p.c
c:\mozilla\repos\obj-inbound\accessible\public\ia2\../../../dist/include/mozilla-config.h(91) : warning C4005: '_WIN32_WINNT' : macro redefinition
        command-line arguments :  see previous definition of '_WIN32_WINNT'
AccessibleAction_p.c
c:\mozilla\repos\obj-inbound\accessible\public\ia2\../../../dist/include/mozilla-config.h(91) : warning C4005: '_WIN32_WINNT' : macro redefinition
        command-line arguments :  see previous definition of '_WIN32_WINNT'
...plus ~20 more under accessible/public/ia2/
}

Caused by the |DEFINES += -DREGISTER_PROXY_DLL -D_WIN32_WINNT=0x400| lines here:
http://mxr.mozilla.org/mozilla-central/search?string=_WIN32_WINNT&find=accessible%2Fpublic%2F
Flags: in-testsuite-
Attached patch Patch v1Splinter Review
Removes the _WIN32_WINNT defines in: accessible/public/msaa/Makefile.in and accessible/public/ia2/Makefile.in , which existed at least as far back as CVS days, but seem redundant given the defines that end up in mozilla-config.h.
Attachment #560834 - Flags: review?(khuey)
Comment on attachment 560834 [details] [diff] [review]
Patch v1

I'd prefer that an a11y peer review this.
Attachment #560834 - Flags: review?(khuey) → review?(surkov.alexander)
This code is 8 years old (bug 199518) and I didn't find a reason why it was introduced. This define isn't used in sources explicitly but I'm not sure if it can affect on dll creation or registration. What possible value are available and how they are used, do Windows header files rely on it, any hint?
khuey or ted might be able to answer that, adding to CC :-)
Comment on attachment 560834 [details] [diff] [review]
Patch v1

r=me
Attachment #560834 - Flags: review?(surkov.alexander) → review+
https://hg.mozilla.org/mozilla-central/rev/0c47234a4021
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.