nsIBidiKeyboard.idl related changes

VERIFIED FIXED in mozilla0.9

Status

()

Core
Internationalization
P1
normal
VERIFIED FIXED
16 years ago
12 years ago

People

(Reporter: Frank Tang, Assigned: Erik van der Poel)

Tracking

Trunk
mozilla0.9
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

16 years ago
This bug is spin off rom bug 62777 and target on the widget only changes.
IBMBIDI team- please attach the latest changes in mozilla/widget directory here
and we should land this earlier since the code do not depend on other part and
layout chagnes depend on this.
kmcclusk@netscape.com nicely agree to review this tomorrow if you can send him
by tomorrow morning. Thanks.
Changes look ok to me.
r=kmcclusk@netscape.com
(Assignee)

Comment 2

16 years ago
I think we need to add nsIBidiKeyboard.idl to MANFIFEST_IDL. Right, Frank?

There is a missing backslash (\) in beos/Makefile.in.

In the Windows version, when GetKeyboardLayoutList returns an unexpected value,
you need to free buf before returning.
(Assignee)

Comment 3

16 years ago
OK, I've made changes to my local files, and will check them in.

sr=erik
Status: NEW → ASSIGNED
OS: Windows NT → All
Priority: -- → P1
Hardware: PC → All
Target Milestone: --- → mozilla0.9
(Assignee)

Comment 4

16 years ago
Checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED

Comment 5

16 years ago
Stupid question, I expect.  Why is it that for all of the platform widgets you
have four files in the platform subdirectory - eg. /qt/ but for windows one of
the files shows in "mozilla/ widget/ src/ build/ nsWinWidgetFactory.cpp" where
the other three are in "mozilla/ widget/ src/ windows/"?


(Assignee)

Comment 6

16 years ago
I don't know. The original author(s) of that file (WinWidgetFactory) might know.

Comment 7

16 years ago
Erik, please mark this bug as verified.
QA Contact: teruko → erik
(Assignee)

Comment 8

16 years ago
I verified that all of these files were checked in and are being built.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.