Closed Bug 687453 Opened 9 years ago Closed 9 years ago

Event dialog: No icons in customize toolbar

Categories

(Calendar :: Dialogs, defect)

Lightning 1.0b4
x86
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: andreasn, Assigned: Fallen)

Details

Attachments

(1 file, 1 obsolete file)

Seems the items in the customize toolbar dialog are missing icons.
Oh, reading other bugs I see also in 1.0b4
Version: Trunk → Lightning 1.0b4
Attached patch Fix - v1 (obsolete) β€” β€” Splinter Review
Untested since I need to rebuild Thunderbird, but this should fix it.
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Attachment #575137 - Flags: review?(richard.marti)
Probably I'm doing something wrong, but I don't see this problem. Under Win7 with TB 8 and Lightning 1.0 the lightning icons are visible in the customizing window during customizing the main toolbar. Also under Linux with TB 9.0a1 and Lightning 1.0b9pre, and now updated to TB 11.0a1 and Lightning 1.3a1 no problem. Under OSX with the Tabs on Top build and Lightning from Aurora channel I'm seeing the icons.
This bug is about the Customize Toolbar dialog in the Edit Event/Task dialog and not the Thunderbird main window.
Summary: No icons in customize toolbar → Event dialog: No icons in customize toolbar
Yes sorry my bad. When I would had checked the patch I would saw it's the Event dialog.
Comment on attachment 575137 [details] [diff] [review]
Fix - v1

The manifest change itself works under OSX, but under Linux and Windows it needs small changes to show the correct icons.
Under Linux the #button-save (Save and Close) is overridden by the TB GTK icon in the customize window. Under Win7 calendar-aero.css needs also !important flags to show the Aero icons and not fragments of the XP icons.

Because of this r-
Attachment #575137 - Flags: review?(richard.marti) → review-
Attached patch Fix - v2 β€” β€” Splinter Review
I hope you don't mind I have extended your patch and ask now you for review.

This patch is your original patch plus the needed theme changes.
Attachment #575137 - Attachment is obsolete: true
Attachment #575647 - Flags: review?(philipp)
Comment on attachment 575647 [details] [diff] [review]
Fix - v2

Looks good, r=philipp and approval for comm-aurora
Attachment #575647 - Flags: review?(philipp) → review+
Pushed to comm-central: http://hg.mozilla.org/comm-central/rev/3296869cb2c5
and to comm-aurora: http://hg.mozilla.org/releases/comm-aurora/rev/cfdd9d8f5cbe
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.2
You need to log in before you can comment on or make changes to this bug.