687468 - [TABLETUI] Tab thumbnail visual tweaks

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Ian Barlow (:ibarlow)]

Attachment: Mockup of comments

Just a bit of polishing on landscape tabs:

1. Reduce height of tab thumbnails by 10%
2. Reduce thumbnail text size by 15%
3. Remove thumbnail borders

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: (1/4) Define font_xxtiny on all themes

Comment 2

[Lucas Rocha (:lucasr)]

Attachment: (2/4) Define border_radius_xsmall on all themes

Comment 3

[Lucas Rocha (:lucasr)]

Attachment: (3/4) Chain tabHeight assignment for simplicity

Comment 4

[Lucas Rocha (:lucasr)]

Attachment: (4/4) Misc design tweaks on tab thumbnails in tablet mode

Comment 5

[Lucas Rocha (:lucasr)]

Requires patch for bug 687287 to be checked in first.

Comment 6

[Lucas Rocha (:lucasr)]

Attachment: Screenshot

Comment 7

[Matt Brubeck (:mbrubeck)]

Comment on attachment 560978 [details] [diff] [review]
(2/4) Define border_radius_xsmall on all themes

Out of curiousity, why exactly 0.31mm?  It seems like 0.32mm would be closer to a whole number of pixels at both 160dpi and 240dpi.

Comment 8

[Matt Brubeck (:mbrubeck)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/fc81b89dc4ac
http://hg.mozilla.org/integration/mozilla-inbound/rev/5629b31668ef
http://hg.mozilla.org/integration/mozilla-inbound/rev/898c71dcfe7c
http://hg.mozilla.org/integration/mozilla-inbound/rev/7004388d9ae8

Comment 9

[Lucas Rocha (:lucasr)]

(In reply to Matt Brubeck (:mbrubeck) from comment #7)
> Comment on attachment 560978 [details] [diff] [review]
> (2/4) Define border_radius_xsmall on all themes
> 
> Out of curiousity, why exactly 0.31mm?  It seems like 0.32mm would be closer
> to a whole number of pixels at both 160dpi and 240dpi.

Just used the value that looked right (as per Barlow's mockups). Feel free to change it to 0.32mm if it doesn't change anything design-wise.

Comment 10

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/7004388d9ae8
https://hg.mozilla.org/mozilla-central/rev/898c71dcfe7c
https://hg.mozilla.org/mozilla-central/rev/5629b31668ef
https://hg.mozilla.org/mozilla-central/rev/fc81b89dc4ac

Comment 11

[Cristian Nicolae (:xti)]

Verified fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110922
Firefox/9.0a1 Fennec/9.0a1
Device: Acer ICONIA A500
OS: Android 3.1