[TABLETUI] Tab thumbnail visual tweaks

VERIFIED FIXED in Firefox 9

Status

Firefox for Android Graveyard
General
VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: ibarlow, Assigned: lucasr)

Tracking

(Blocks: 1 bug, {polish})

Firefox 9
Firefox 9
All
Android
polish
Dependency tree / graph

Details

Attachments

(6 attachments)

(Reporter)

Description

7 years ago
Created attachment 560917 [details]
Mockup of comments

Just a bit of polishing on landscape tabs:

1. Reduce height of tab thumbnails by 10%
2. Reduce thumbnail text size by 15%
3. Remove thumbnail borders
Blocks: 655762
Keywords: polish
OS: Mac OS X → Android
Hardware: x86 → All
(Assignee)

Updated

7 years ago
Assignee: nobody → lucasr.at.mozilla
(Assignee)

Comment 1

7 years ago
Created attachment 560976 [details] [diff] [review]
(1/4) Define font_xxtiny on all themes
Attachment #560976 - Flags: review?(mbrubeck)
(Assignee)

Comment 2

7 years ago
Created attachment 560978 [details] [diff] [review]
(2/4) Define border_radius_xsmall on all themes
Attachment #560978 - Flags: review?(mbrubeck)
(Assignee)

Comment 3

7 years ago
Created attachment 560979 [details] [diff] [review]
(3/4) Chain tabHeight assignment for simplicity
Attachment #560979 - Flags: review?(mbrubeck)
(Assignee)

Comment 4

7 years ago
Created attachment 560980 [details] [diff] [review]
(4/4) Misc design tweaks on tab thumbnails in tablet mode
Attachment #560980 - Flags: review?(mbrubeck)
(Assignee)

Comment 5

7 years ago
Requires patch for bug 687287 to be checked in first.
Depends on: 687287
(Assignee)

Comment 6

7 years ago
Created attachment 560981 [details]
Screenshot
Attachment #560976 - Flags: review?(mbrubeck) → review+
Comment on attachment 560978 [details] [diff] [review]
(2/4) Define border_radius_xsmall on all themes

Out of curiousity, why exactly 0.31mm?  It seems like 0.32mm would be closer to a whole number of pixels at both 160dpi and 240dpi.
Attachment #560978 - Flags: review?(mbrubeck) → review+
Attachment #560979 - Flags: review?(mbrubeck) → review+
Attachment #560980 - Flags: review?(mbrubeck) → review+
(Assignee)

Comment 9

7 years ago
(In reply to Matt Brubeck (:mbrubeck) from comment #7)
> Comment on attachment 560978 [details] [diff] [review]
> (2/4) Define border_radius_xsmall on all themes
> 
> Out of curiousity, why exactly 0.31mm?  It seems like 0.32mm would be closer
> to a whole number of pixels at both 160dpi and 240dpi.

Just used the value that looked right (as per Barlow's mockups). Feel free to change it to 0.32mm if it doesn't change anything design-wise.

Comment 10

7 years ago
https://hg.mozilla.org/mozilla-central/rev/7004388d9ae8
https://hg.mozilla.org/mozilla-central/rev/898c71dcfe7c
https://hg.mozilla.org/mozilla-central/rev/5629b31668ef
https://hg.mozilla.org/mozilla-central/rev/fc81b89dc4ac
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → Firefox 9
Verified fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110922
Firefox/9.0a1 Fennec/9.0a1
Device: Acer ICONIA A500
OS: Android 3.1
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.