Closed Bug 687480 Opened 12 years ago Closed 11 years ago

Memory usage spike detected in Mozmill Endurance tests

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Version:
9 Branch
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED INCOMPLETE

People

(Reporter: u279076, Unassigned)

Details

(Keywords: qawanted, regression, Whiteboard: [MemShrink:P2]) 

There appears to be a memory spike of about 10MB between Sept 6 and Sept 7 on the Mac nightlies. 

In the two weeks previous, we averaged around 160MB consistently.
Since September 7th, we are averaging around 170MB consistently.

Report 2011-09-06 (163MB):
http://mozmill-release.brasstacks.mozilla.com/#/endurance/report/b2f105bf5adf3d9f861770c4a9b4d5d6

Report 2011-09-07 (173MB):
http://mozmill-release.brasstacks.mozilla.com/#/endurance/report/5fdc9d8340b415e9a2e6a934ad122af5

Changeset:
http://hg.mozilla.org/mozilla-central/rev/09935ede3c77
Keywords: regression
On a superficial pass, this looks like it could be a culprit:

Ed Morley — Backout a422b9ff0a9e (bug 591780 part 1) for causing 8% Ts regression on multiple platforms; a=khuey

http://hg.mozilla.org/mozilla-central/rev/db9e99d537f2
Hard to say. I would propose that we do our own builds and find the exact changeset this way. Dave or Anthony, can one of you do this?
(In reply to Henrik Skupin (:whimboo) from comment #3)
> Hard to say. I would propose that we do our own builds and find the exact
> changeset this way. Dave or Anthony, can one of you do this?

I won't have time for this due to Firefox 7 release testing. Dave, can you investigate?
The TI merge is *much* more likely.
(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #5)
> The TI merge is *much* more likely.

I would agree. Lets add Brian and Nicholas to the bug for further input.
The TI merge pulled in one feature patch (bug 663138) and several bug fixes.  The fixes should not have affected anything, and bug 663138 made a few memory-related changes:

- Moved some state from JSScript into TypeScript, which will be a net reduction in memory usage (there are far fewer TypeScripts than JSScripts).

- Allocate a small data structure for function scripts which are nested in each other.  These are unusual on the web, and the memory from these would not account for even remotely close to 6% of explicit memory.

It's possible TI is the culprit, but only if something unintentionally broke with that merge.  Did a similar regression show up on other platforms?
Anthony, it would be great if you can bisect the range in comment 1 to see which patch in the range is causing this.  Would you mind doing that please?
Keywords: qawanted
Whiteboard: [MemShrink] → [MemShrink:P2]
(In reply to Ehsan Akhgari [:ehsan] from comment #8)
> Anthony, it would be great if you can bisect the range in comment 1 to see
> which patch in the range is causing this.  Would you mind doing that please?

How do you "bisect the range"?
I can show it to you, but you will have to have the build system installed on your machine: https://developer.mozilla.org/En/Simple_Firefox_build#Mac
(In reply to Henrik Skupin (:whimboo) from comment #10)
> I can show it to you, but you will have to have the build system installed
> on your machine: https://developer.mozilla.org/En/Simple_Firefox_build#Mac

I'm going to be very busy over the next week or so with Firefox 7 release work. I'll approach our outsource PM to assign this out. Henrik, I will have whomever get in touch with you once assigned -- if that is okay?
I've tried tracking down the changeset that caused this locally, however as the results of each run can vary I haven't had any success yet. I'll continue to look into this.
Any progress here?
I wasn't able to identify the changeset that caused this. Unfortunately brasstacks is now down so it's not going to be possible to see the original reports. I've added bug 716671 as a dependency.
I suspect this bug will never go anywhere.  Please reopen if you disagree.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → INCOMPLETE
Yeah, I agree, the trail ran dead. We can open a new bug if we find a more concrete regression window to investigate.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.