Application should manage the search tile

RESOLVED FIXED in M1

Status

RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: st3fan, Assigned: sfoster)

Tracking

x86
Mac OS X

Details

(Reporter)

Description

7 years ago
The Bing and Twitter searches currently return the whole search tile. Including the search tabs on the left.

This should be refactored so that the search engines only return a <div> or maybe <iframe> that contains the results.

The app should manage the container and the tab selection.

The app can then also show a spinner while the search results are being loaded.
(Reporter)

Updated

7 years ago
Target Milestone: --- → M1

Updated

7 years ago
Assignee: nobody → kparlante

Updated

7 years ago
Assignee: kparlante → sfoster
Blocks: 687509
(Assignee)

Comment 1

7 years ago
This refactoring has taken place now (currently in the backbone-js branch), so an  HTML fragment is returned (in a JSON envelope). 
 
I can't yet confirm the bing/twitter search provider tabs are switching correctly, as twitter searches have temporarily stopped working. but that /should/ be the case.
Status: NEW → ASSIGNED
(Reporter)

Comment 2

7 years ago
It is also very easy to change the search API to return real JSON results instead of HTML. Is that something you guys would prefer?

Updated

7 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.