Last Comment Bug 687520 - Add DSPAM to "Trust junk mail headers set by" Option
: Add DSPAM to "Trust junk mail headers set by" Option
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Preferences (show other bugs)
: 6 Branch
: x86_64 Windows 7
: -- enhancement (vote)
: Thunderbird 11.0
Assigned To: Jim McDonald
:
Mentors:
Depends on:
Blocks: 323144 426504
  Show dependency treegraph
 
Reported: 2011-09-19 10:16 PDT by Jim McDonald
Modified: 2012-03-03 00:42 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Patch for additional spam system detection for junk mail (3.53 KB, patch)
2011-09-19 10:28 PDT, Jim McDonald
standard8: review+
Details | Diff | Splinter Review
Updated patch (2.55 KB, patch)
2011-12-02 03:54 PST, Mark Banner (:standard8) (afk until 26th July)
standard8: review+
Details | Diff | Splinter Review

Description Jim McDonald 2011-09-19 10:16:08 PDT
At current the "Trust junk mail headers set by" dropdown in the per-account junk mail settings only contains SpamAssassin and SpamPal.  I would like it to also contain DSPAM.
Comment 1 Jim McDonald 2011-09-19 10:21:56 PDT
I have put together a patch that provides this enhancement, along with those requested for Bogofilter (bug 323144) and POPFile (bug 426504).  It is against the current trunk build.
Comment 2 Jim McDonald 2011-09-19 10:28:15 PDT
Created attachment 560956 [details] [diff] [review]
Patch for additional spam system detection for junk mail
Comment 3 Mark Banner (:standard8) (afk until 26th July) 2011-12-02 03:50:35 PST
Comment on attachment 560956 [details] [diff] [review]
Patch for additional spam system detection for junk mail

Sorry for the delay in getting to this. Thanks for doing all of these.

diff --git a/mail/installer/removed-files.in b/mail/installer/removed-files.in

The changes to this file aren't right. We don't need to remove any files as they've never been shipped (yet). You do need to patch the mail/installer/package-manifest.in file as you have done with the suite version.

Normally, I'd give you r- and request you update the patch. However, as this is the first time for you and I've been a bit slow, I'll update the patch for you.
Comment 4 Mark Banner (:standard8) (afk until 26th July) 2011-12-02 03:54:03 PST
Created attachment 578543 [details] [diff] [review]
Updated patch

I actually noticed that mail's package-manifest.in has isp/* so we'll package everything there already. So this patch just drops the removed-files.in changes.
Comment 5 Mark Banner (:standard8) (afk until 26th July) 2011-12-02 03:58:05 PST
Checked in: http://hg.mozilla.org/comm-central/rev/e9a00fadaf6c

Thanks Jim.
Comment 6 Ludovic Hirlimann [:Usul] 2011-12-02 07:20:00 PST
(In reply to Mark Banner (:standard8) from comment #5)
> Checked in: http://hg.mozilla.org/comm-central/rev/e9a00fadaf6c
> 
> Thanks Jim.

Ain't the right changeset
Comment 7 Mark Banner (:standard8) (afk until 26th July) 2011-12-02 09:05:44 PST
This one is:
http://hg.mozilla.org/comm-central/rev/eeab443cdb49

Note You need to log in before you can comment on or make changes to this bug.