Closed Bug 687520 Opened 8 years ago Closed 8 years ago

Add DSPAM to "Trust junk mail headers set by" Option

Categories

(Thunderbird :: Preferences, enhancement)

6 Branch
x86_64
Windows 7
enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 11.0

People

(Reporter: Jim, Assigned: Jim)

References

Details

Attachments

(1 file, 1 obsolete file)

At current the "Trust junk mail headers set by" dropdown in the per-account junk mail settings only contains SpamAssassin and SpamPal.  I would like it to also contain DSPAM.
I have put together a patch that provides this enhancement, along with those requested for Bogofilter (bug 323144) and POPFile (bug 426504).  It is against the current trunk build.
Attachment #560956 - Flags: review?
Attachment #560956 - Flags: review? → review?(mbanner)
Assignee: nobody → Jim
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Comment on attachment 560956 [details] [diff] [review]
Patch for additional spam system detection for junk mail

Sorry for the delay in getting to this. Thanks for doing all of these.

diff --git a/mail/installer/removed-files.in b/mail/installer/removed-files.in

The changes to this file aren't right. We don't need to remove any files as they've never been shipped (yet). You do need to patch the mail/installer/package-manifest.in file as you have done with the suite version.

Normally, I'd give you r- and request you update the patch. However, as this is the first time for you and I've been a bit slow, I'll update the patch for you.
Attachment #560956 - Flags: review?(mbanner) → review+
Attached patch Updated patchSplinter Review
I actually noticed that mail's package-manifest.in has isp/* so we'll package everything there already. So this patch just drops the removed-files.in changes.
Attachment #560956 - Attachment is obsolete: true
Attachment #578543 - Flags: review+
Checked in: http://hg.mozilla.org/comm-central/rev/e9a00fadaf6c

Thanks Jim.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 11.0
(In reply to Mark Banner (:standard8) from comment #5)
> Checked in: http://hg.mozilla.org/comm-central/rev/e9a00fadaf6c
> 
> Thanks Jim.

Ain't the right changeset
You need to log in before you can comment on or make changes to this bug.