687565 - Orion in JS mode doesn't highlight the 'let' keyword

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[(no longer active)]

The same thing might also be true for new js keywords.

Comment 1

[Kevin Dangoor]

Filed upstream.

https://bugs.eclipse.org/bugs/show_bug.cgi?id=358478

Comment 2

[Kevin Dangoor]

This has been fixed upstream.

Comment 3

[Mihai Sucan [:msucan]]

We need a new bug about updating our Orion code from upstream.

We should aim to have more of their upstream features. Also, we should look into using stable releases - their next stable release (milestone 0.3), which is scheduled for late October.

Comment 4

[Mihai Sucan [:msucan]]

I have filed bug 692807 about updating our Orion code from upstream.

I am now going through the Orion/Source Editor/Scratchpad bug reports we have to triage them and compare against the latest upstream Orion code I have locally. (patience please with the bugzilla spam :) )

Thank you!

Comment 5

[Mihai Sucan [:msucan]]

Confirmed. This is fixed upstream.

Comment 6

[Mihai Sucan [:msucan]]

This is now fixed. Bug 692807 landed.

Comment 7

[Alex Lakatos[:AlexLakatos]]

This is VERIFIED on Build identifier: Mozilla/5.0 (X11; Linux i686; rv:10.0a1) Gecko/20111107 Firefox/10.0a1
Also, checked all keywords from https://developer.mozilla.org/en/JavaScript/Reference/Reserved_Words and they are highlighted. Am I missing some keywords that should be highlighted?

Comment 8

[Mihai Sucan [:msucan]]

(In reply to Alex Lakatos from comment #7)
> This is VERIFIED on Build identifier: Mozilla/5.0 (X11; Linux i686;
> rv:10.0a1) Gecko/20111107 Firefox/10.0a1
> Also, checked all keywords from
> https://developer.mozilla.org/en/JavaScript/Reference/Reserved_Words and
> they are highlighted. Am I missing some keywords that should be highlighted?

Hopefully not. Thank you for your testing!