687657 - Affiliates: Add the ability for users to choose their locale instead of auto-detect

Status: VERIFIED FIXED

(Firefox Affiliates Graveyard :: affiliates.mozilla.org, defect)

Description

[Chris More [:cmore]]

Currently, users are only shown banners for their current locale and they will have to manually switch their locale to view other banners. We should give the users the ability to show banners for different locales.

Comment 1

[Osmose [:osmose, :mkelly]]

I'll take the development work on this, but we'll need design work done on this first.

Comment 2

[Chelsea Novak [:chelsea]]

Ty knows that there are some design changes needed. Is the meeting we have with him next week early enough to get this going?

Comment 3

[Osmose [:osmose, :mkelly]]

Sure, we have plenty of time, just wanted to make sure someone didn't take the bug before we designed it. :P

Comment 4

[Osmose [:osmose, :mkelly]]

So here's a proposal based on input from jgrlicky:

We determine a user's 'locale' based on the locale in the url, IE at https://affiliates.mozilla.org/de/new/1, the user's locale is 'de'. This is automatically set based on the user's accept-language header when they visit the site without any locale set.

On the 1st and 2nd wizard steps, users see all available banners. Any banners that are available in the user's locale are displayed in that language. Banners that are not available in the user's locale are still displayed, but instead in en-US (or, lacking that, whatever locale they are available in).

On the 3rd step, along with the Size and Color selections, users can also choose the locale they want their banner in from a dropdown selection.

Comment 5

[Osmose [:osmose, :mkelly]]

Attachment: Mockup of language dropdown

Comment 6

[[github robot]]

Commits pushed to https://github.com/mozilla/affiliates

https://github.com/mozilla/affiliates/commit/f6d87b3fa784a7f15e808bffbb08ce7b5784e602
Move locale choice to 3rd step of banner wizard.

bug 687657

https://github.com/mozilla/affiliates/commit/8f5f0efb8e4dfa16359e74009118f6bb36dc9cf6
Fix and add tests for moved locale choice.

fix bug 687657

Comment 7

[Matt Brandt [:mbrandt]]

QA verified on stage: Functionally a user can now browse and select other local's banners. Banner snippets are saved and generated as expected. 

Bug 716122 to track known behavior where the my_banners page does not quickly display newly "created" banner snippets.