Closed
Bug 687657
Opened 13 years ago
Closed 13 years ago
Affiliates: Add the ability for users to choose their locale instead of auto-detect
Categories
(Firefox Affiliates Graveyard :: affiliates.mozilla.org, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
1.1
People
(Reporter: cmore, Assigned: osmose)
References
Details
(Whiteboard: [dev][design][ux][rel:1/12/2012])
Attachments
(1 file)
48.91 KB,
image/png
|
Details |
Currently, users are only shown banners for their current locale and they will have to manually switch their locale to view other banners. We should give the users the ability to show banners for different locales.
Reporter | ||
Updated•13 years ago
|
Target Milestone: --- → 1.1
Reporter | ||
Updated•13 years ago
|
Whiteboard: [dev]
Assignee | ||
Comment 1•13 years ago
|
||
I'll take the development work on this, but we'll need design work done on this first.
Comment 2•13 years ago
|
||
Ty knows that there are some design changes needed. Is the meeting we have with him next week early enough to get this going?
Assignee | ||
Comment 3•13 years ago
|
||
Sure, we have plenty of time, just wanted to make sure someone didn't take the bug before we designed it. :P
Assignee | ||
Comment 4•13 years ago
|
||
So here's a proposal based on input from jgrlicky: We determine a user's 'locale' based on the locale in the url, IE at https://affiliates.mozilla.org/de/new/1, the user's locale is 'de'. This is automatically set based on the user's accept-language header when they visit the site without any locale set. On the 1st and 2nd wizard steps, users see all available banners. Any banners that are available in the user's locale are displayed in that language. Banners that are not available in the user's locale are still displayed, but instead in en-US (or, lacking that, whatever locale they are available in). On the 3rd step, along with the Size and Color selections, users can also choose the locale they want their banner in from a dropdown selection.
Assignee: nobody → mkelly
Status: NEW → ASSIGNED
Assignee | ||
Comment 5•13 years ago
|
||
Comment 6•13 years ago
|
||
Commits pushed to https://github.com/mozilla/affiliates https://github.com/mozilla/affiliates/commit/f6d87b3fa784a7f15e808bffbb08ce7b5784e602 Move locale choice to 3rd step of banner wizard. bug 687657 https://github.com/mozilla/affiliates/commit/8f5f0efb8e4dfa16359e74009118f6bb36dc9cf6 Fix and add tests for moved locale choice. fix bug 687657
Updated•13 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•13 years ago
|
Whiteboard: [dev][design][ux] → [dev][design][ux][rel:1/12/2012]
Comment 7•12 years ago
|
||
QA verified on stage: Functionally a user can now browse and select other local's banners. Banner snippets are saved and generated as expected. Bug 716122 to track known behavior where the my_banners page does not quickly display newly "created" banner snippets.
Status: RESOLVED → VERIFIED
Updated•12 years ago
|
Product: Websites → Firefox Affiliates
Updated•9 years ago
|
Product: Firefox Affiliates → Firefox Affiliates Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•