[SkipList]Add fastcopy_I to prefix skiplist

RESOLVED FIXED in 2.4.4

Status

Socorro
Infra
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: gps, Assigned: laura)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

(Reporter)

Description

6 years ago
'fastcopy_I' is part of the implementation of memcpy, realloc, etc in msvcrXX.dll on Windows. It doesn't really add any value to stack traces since it isn't a public API, so it should probably be skipped from the frame list entirely.

The callers of fastcopy_I should be preserved in the frame list, however, as errors could be the result of a heap corruption that the calling frame has nothing to do with.

An example crash report with fastcopy_I at the top of the stack is https://crash-stats.mozilla.com/report/index/5c3c3f81-23fb-4a6e-a032-ba6b22110919.
(Assignee)

Updated

6 years ago
Assignee: nobody → laura
Target Milestone: --- → 2.2.4
(Assignee)

Comment 1

6 years ago
All of the memcpy type functions are right now in the prefix list rather than the irrelevant list - just want to confirm which of those you want, since it sounds like you want to add this one to the irrelevant list.

See definitions here:
https://wiki.mozilla.org/Breakpad/Skip_List_How_To
(Reporter)

Comment 2

6 years ago
fastcopy_I is a private function in Microsoft's implementation of memory allocation functions. It will always be called by a public API, like memcpy, realloc, memmove, etc. I would think it would be safe to hide. But, being able to search on this symbol might be a good way to aggregate all the memory-related/heap-corruption bugs on Windows. So maybe it is best to move to the prefix list.


I'll defer to people with more experience.
(Assignee)

Updated

6 years ago
Target Milestone: 2.2.4 → 2.3
(Assignee)

Comment 3

6 years ago
Waiting on info to implement.
Target Milestone: 2.3 → ---
Summary: Add fastcopy_I to skiplist → [SkipList]Add fastcopy_I to skiplist

Updated

6 years ago
Blocks: 598774
Component: Socorro → General
Product: Webtools → Socorro
(Assignee)

Updated

6 years ago
Component: General → Infra

Updated

6 years ago
Summary: [SkipList]Add fastcopy_I to skiplist → [SkipList]Add fastcopy_I to prefix skiplist
(Assignee)

Updated

6 years ago
Target Milestone: --- → 2.4.4
(Assignee)

Comment 4

6 years ago
Kairo asked me to do this today, so without more input from anyone, I'm adding it to the prefix list.
(Assignee)

Comment 5

6 years ago
In https://github.com/mozilla/socorro/pull/377

Comment 6

6 years ago
Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/6d551c0a63f04f58e7212a451d0fab2495426e60
Fixes bug 687672, add fastcopy_I to the prefix skiplist

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Updated

6 years ago
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.