Closed
Bug 687680
Opened 13 years ago
Closed 13 years ago
make oauth dialogs detect when they're not big enough
Categories
(Mozilla Labs :: F1, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: davida, Unassigned)
Details
Attachments
(2 files)
90.79 KB,
image/png
|
Details | |
581 bytes,
patch
|
mixedpuppy
:
review+
|
Details | Diff | Splinter Review |
STR: open F1, configure a twitter account, type a bad username or pw -- you'll get a dialog which no longer fits in the window. See attached screenshot.
Comment 1•13 years ago
|
||
Attaching a patch which isn't quite perfect (eg, the bottom line of text may still be cut off) but it is an improvement and I can't work out the "perfect" solution. Patch is too trivial to bother with a branch etc...
Attachment #561361 -
Flags: review?(mixedpuppy)
Comment 2•13 years ago
|
||
Actually, one improvement to that patch would be to return after the: this._checkForRedirect(aRequest.name, aWebProgress); call. ie, don't do the resize after we determine the auth is complete.
Updated•13 years ago
|
Attachment #561361 -
Flags: review?(mixedpuppy) → review+
Comment 3•13 years ago
|
||
pushed to oauthorizer develop branch.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•