Closed Bug 687680 Opened 13 years ago Closed 13 years ago

make oauth dialogs detect when they're not big enough

Categories

(Mozilla Labs :: F1, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: davida, Unassigned)

Details

Attachments

(2 files)

Attached image screenshot OS X
STR: open F1, configure a twitter account, type a bad username or pw -- you'll get a dialog which no longer fits in the window.  See attached screenshot.
Attaching a patch which isn't quite perfect (eg, the bottom line of text may still be cut off) but it is an improvement and I can't work out the "perfect" solution.  Patch is too trivial to bother with a branch etc...
Attachment #561361 - Flags: review?(mixedpuppy)
Actually, one improvement to that patch would be to return after the:

this._checkForRedirect(aRequest.name, aWebProgress);

call.  ie, don't do the resize after we determine the auth is complete.
Attachment #561361 - Flags: review?(mixedpuppy) → review+
pushed to oauthorizer develop branch.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: