make oauth dialogs detect when they're not big enough

RESOLVED FIXED

Status

Mozilla Labs
F1
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: davida, Unassigned)

Tracking

Details

Attachments

(2 attachments)

(Reporter)

Description

7 years ago
Created attachment 561039 [details]
screenshot OS X

STR: open F1, configure a twitter account, type a bad username or pw -- you'll get a dialog which no longer fits in the window.  See attached screenshot.
Created attachment 561361 [details] [diff] [review]
Resize window each time document finishes loading.

Attaching a patch which isn't quite perfect (eg, the bottom line of text may still be cut off) but it is an improvement and I can't work out the "perfect" solution.  Patch is too trivial to bother with a branch etc...
Attachment #561361 - Flags: review?(mixedpuppy)
Actually, one improvement to that patch would be to return after the:

this._checkForRedirect(aRequest.name, aWebProgress);

call.  ie, don't do the resize after we determine the auth is complete.
Attachment #561361 - Flags: review?(mixedpuppy) → review+
pushed to oauthorizer develop branch.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.