Closed
Bug 687696
Opened 13 years ago
Closed 13 years ago
test_IHistory.cpp uses places without a profile
Categories
(Toolkit :: Places, defect)
Tracking
()
RESOLVED
FIXED
mozilla9
People
(Reporter: espindola, Assigned: espindola)
References
Details
Attachments
(2 files, 1 obsolete file)
5.27 KB,
patch
|
mak
:
review+
|
Details | Diff | Splinter Review |
629 bytes,
patch
|
mak
:
review+
|
Details | Diff | Splinter Review |
see https://bugzilla.mozilla.org/show_bug.cgi?id=673017#c307 as to why it should have one.
Assignee | ||
Comment 1•13 years ago
|
||
It looks like test_IHistory *has* a profile. The issues are
* the shutdown messages not being sent
* The bookmark, annotation and favicon services not being used by the test (they are lazily initiated).
Assignee | ||
Comment 2•13 years ago
|
||
Attachment #561179 -
Flags: review?(mak77)
Comment 3•13 years ago
|
||
(In reply to Rafael Ávila de Espíndola (:espindola) from comment #1)
> * The bookmark, annotation and favicon services not being used by the test
> (they are lazily initiated).
Why should this matter?
Assignee | ||
Comment 4•13 years ago
|
||
Comment 5•13 years ago
|
||
Ah ok, I see, you just don't want to startup the services if they are not needed. that's ok.
The shotdown observer should be moved to places_test_harness.h and places_test_harness_tail.h so that any newly added test will use it, I don't understand why it has to listen to both will-shutdown and shutdown, could't it just listen to xpcom-will-shutdown and notify both profile notifications with NotifyObservers? The order should be guarantee
Assignee | ||
Comment 6•13 years ago
|
||
(In reply to Marco Bonardo [:mak] from comment #3)
> (In reply to Rafael Ávila de Espíndola (:espindola) from comment #1)
> > * The bookmark, annotation and favicon services not being used by the test
> > (they are lazily initiated).
>
> Why should this matter?
The getter tries to start those during shutdown...
Assignee | ||
Comment 7•13 years ago
|
||
Attachment #561179 -
Attachment is obsolete: true
Attachment #561179 -
Flags: review?(mak77)
Attachment #561195 -
Flags: review?(mak77)
Assignee | ||
Comment 8•13 years ago
|
||
Comment 9•13 years ago
|
||
Comment on attachment 561195 [details] [diff] [review]
new patch
Review of attachment 561195 [details] [diff] [review]:
-----------------------------------------------------------------
::: toolkit/components/places/nsNavHistory.cpp
@@ +5129,4 @@
> NS_ENSURE_SUCCESS(rv, rv);
>
> // nsNavBookmarks
> + nsNavBookmarks *bookmarks = nsNavBookmarks::GetBookmarksServiceIfAvailable();
while here, please fix pointer style (correct is toward type)
and remove these useless comments like // nsNavBookmarks, // nsAnnotationService, // nsFaviconService... they are just anticipating what is written on the immediately following line.
::: toolkit/components/places/tests/cpp/places_test_harness.h
@@ +338,5 @@
> +class ShutdownObserver : public nsIObserver
> +{
> +public:
> + NS_DECL_ISUPPORTS
> + ShutdownObserver() {
newline between decl and between methods (also the other method below) pls
brace on newline too
@@ +340,5 @@
> +public:
> + NS_DECL_ISUPPORTS
> + ShutdownObserver() {
> + nsCOMPtr<nsIObserverService> observerService =
> + do_GetService(NS_OBSERVERSERVICE_CONTRACTID);
nit: don't remember if in this specific harness we may use mozilla::services, it would be nice.
@@ +350,5 @@
> + NS_IMETHOD Observe(nsISupports* aSubject,
> + const char* aTopic,
> + const PRUnichar* aData)
> + {
> + if (strcmp(aTopic, NS_XPCOM_SHUTDOWN_OBSERVER_ID) == 0) {
I think it would be a bit more real if we listen to will-shutdown rather than shutdown (since ideally profile notifications are supposed to happen before)
@@ +354,5 @@
> + if (strcmp(aTopic, NS_XPCOM_SHUTDOWN_OBSERVER_ID) == 0) {
> + nsCOMPtr<nsIObserverService> os =
> + do_GetService(NS_OBSERVERSERVICE_CONTRACTID);
> + os->NotifyObservers(nsnull, TOPIC_PROFILE_TEARDOWN, nsnull);
> + os->NotifyObservers(nsnull, TOPIC_PROFILE_CHANGE, nsnull);
please cast to (void) if you don't care about result value, per our code style
Attachment #561195 -
Flags: review?(mak77) → review+
Assignee | ||
Comment 10•13 years ago
|
||
Comment 11•13 years ago
|
||
Assignee: nobody → respindola
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
Comment 12•13 years ago
|
||
Comment on attachment 561195 [details] [diff] [review]
new patch
>--- a/toolkit/components/places/tests/cpp/places_test_harness_tail.h
>+++ b/toolkit/components/places/tests/cpp/places_test_harness_tail.h
>@@ -115,6 +115,8 @@ main(int aArgc,
> char** aArgv)
> {
> ScopedXPCOM xpcom(TEST_NAME);
>+ nsCOMPtr<ShutdownObserver> shutdownObserver = new ShutdownObserver();
ShutdownObserver is not an interface, so nsCOMPtr<ShutdownObserver> is illegal.
Comment 13•13 years ago
|
||
(In reply to Ms2ger from comment #12)
> ShutdownObserver is not an interface, so nsCOMPtr<ShutdownObserver> is
> illegal.
Right, actually it will work correctly but should be a nsRefPtr, thanks for pointing that out.
Comment 14•13 years ago
|
||
Not sure if this or bug 683400 is responsible for the recent Ts regression:
https://groups.google.com/forum/#!topic/mozilla.dev.tree-management/WOlX-ghe0H4
http://graphs-new.mozilla.org/graph.html#tests=[[54,63,14],[54,63,15]]&sel=1316423909867.185,1316699577328&displayrange=7&datatype=running
Comment 15•13 years ago
|
||
(In reply to Ed Morley [:edmorley] from comment #14)
> Not sure if this or bug 683400 is responsible for the recent Ts regression:
>
> https://groups.google.com/forum/#!topic/mozilla.dev.tree-management/WOlX-
> ghe0H4
>
> http://graphs-new.mozilla.org/graph.html#tests=[[54,63,14],[54,63,
> 15]]&sel=1316423909867.185,1316699577328&displayrange=7&datatype=running
Or just the Talos downtime yesterday. this bug can
t be responsible for any Talos change, it's a test-only fix.
Comment 16•13 years ago
|
||
ehr, nevermind, it modifies the shutdown process. But ideally can't make it slower since in the worst case is same as before.
Assignee | ||
Comment 17•13 years ago
|
||
Attachment #561748 -
Flags: review?(mak77)
Updated•13 years ago
|
Attachment #561748 -
Flags: review?(mak77) → review+
Comment 18•13 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•