687706 - remove "Test App.app" and its troublesome symlink

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Brian Warner [:warner :bwarner]]

Attachment: remove TestApp.app and change code to stop using it

as Myk noticed (http://groups.google.com/group/mozilla-labs-jetpack/browse_thread/thread/c71cea4749291ce1?hl=en), the symlink in "python-lib/cuddlefish/Test App.app" is troublesome (doesn't work on git under windows), and from what I can tell, that whole "Test App" directory is effectively unused. So let's get rid of it.

Comment 1

[Brian Warner [:warner :bwarner]]

Comment on attachment 561057 [details]
remove TestApp.app and change code to stop using it

I don't know if this patch capture my intent correctly (patches which delete binary files aren't always possible to represent in text), but it's basically 'rm -f python-lib/cuddlefish/Test\ App.app' and then some changes to __init__.py to stop using it under darwin.

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 561057 [details]
remove TestApp.app and change code to stop using it

Note: I ran into trouble applying the patch, as `git apply` complained "error: cannot apply binary patch to 'python-lib/cuddlefish/Test App.app/Contents/MacOS/xulrunner' without full index line."

`git diff --full-index` generated a patch without this problem, as did `git diff --binary` (which implies `--full-index`).

Comment 3

[Brian Warner [:warner :bwarner]]

Landed, in https://github.com/mozilla/addon-sdk/commit/9efdd448bb2ca6a1e6c557f4a504feefb957d271

Thanks for the tip about --full-index!