Javascript to load thumbnails is not correct

RESOLVED FIXED in M1

Status

RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: st3fan, Assigned: sfoster)

Tracking

x86
Mac OS X

Details

(Reporter)

Description

7 years ago
The current code simply requests all thumbnails every second or so. What it should do instead is call /thumbnails/$JOBID to find out which thumbnails are actually available/ready.

Stefan has some old code that he wrote while testing the thumbnailer that shows how to do this.

This will minimize the number of requests a lot.
(Reporter)

Updated

7 years ago
Assignee: nobody → sarentz
(Reporter)

Updated

7 years ago
Target Milestone: --- → M1
Depends on: 704948
Assignee: sarentz → sfoster
(Assignee)

Comment 1

7 years ago
I've committed some changes to the js code which pay attention now to the status of each thumbnail and monitors (polls) the /thumbnails/{jobid} for updates. There's a thumbnails.js module with all thumbnail-related stuff removed from main.js and relocated there. 

But.. it doesnt yet make use of the response from /thumbnails/{jobid}. As I believe this has changed (or is at least documented now) in the new work on the thumbnails api, I can revisit this and hook it up when that lands.
Status: NEW → ASSIGNED

Updated

7 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.