Closed
Bug 687729
Opened 13 years ago
Closed 13 years ago
Move SelectionHelper and PageActions code from common-ui.js out of startup
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 9
People
(Reporter: mbrubeck, Assigned: mbrubeck)
References
Details
(Keywords: mobile, perf, Whiteboard: [inbound][QA-])
Attachments
(2 files, 1 obsolete file)
|
1.70 KB,
patch
|
Details | Diff | Splinter Review | |
|
58.00 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
This moves about 500 lines of JS parsing out of the startup path, and it moves a small amount of code out of the UIReadyDelayed handler by making it fully lazy.
Attachment #561079 -
Flags: review?(mark.finkle)
|
Assignee | |
Comment 1•13 years ago
|
||
All of the code in the added files is unchanged (just moved from common-ui.js) except for these changes in PageActions.
|
|
Assignee | |
Comment 2•13 years ago
|
||
We can also move WebappsUI out of here without making any changes.
Attachment #561079 -
Attachment is obsolete: true
Attachment #561079 -
Flags: review?(mark.finkle)
Attachment #561083 -
Flags: review?(mark.finkle)
|
||
Comment 3•13 years ago
|
||
Comment on attachment 561083 [details] [diff] [review] patch v2 Nice improvements
Attachment #561083 -
Flags: review?(mark.finkle) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/e0ea0a7ecbee
Whiteboard: [inbound]
|
||
Comment 5•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e0ea0a7ecbee
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 9
|
||
Updated•13 years ago
|
Whiteboard: [inbound] → [inbound][QA?]
|
||
Updated•13 years ago
|
Whiteboard: [inbound][QA?] → [inbound][QA-]
You need to log in
before you can comment on or make changes to this bug.
Description
•