687820 - about:config should check for invalid characters when creating a new pref

Status: RESOLVED WONTFIX

(Firefox :: Settings UI, defect)

Description

[Ed Morley [:emorley]]

+++ This bug was initially created as a clone of Bug #675794 +++

(sys.sgx from bug 675794 comment #8)
> New keys/values should should also strip *all* invalid characters.
> I didnt start a new bug, as this can be fixed under the same topic.
> 
> How to reproduce:
> 1. Right click-> New alphanumeric
> 2. Enter any key that is a product of Alt+(num), ie ☼, ►, •, etc.
> 
> We should change at least the key creation to include only valid key
> characters.
> 
> Thanks

Broken out from that bug, since a patch has already landed there.

Comment 1

[Felix Fung (:felix)]

So for clarity, config names _can_ contain non-alphanumeric characters, most obviously the dot '.' and underscore '_'. And in fact, I think I see a '{' in one of my default config names as well. Is there any reason we should aggressively invalidate config names? And if so, what is a clearer spec about what should be invalid?

Comment 2

[sys.sgx]

Felix, you're right about these characters. It's common to have a '_' or '.' on configuration, but there's no need to have characters like ☼ in the names or values of the config. In other words, we could strip all characters that are not commonly used by JS. Most of them are found in the first series of combinations of Alt+(num).

Comment 3

[:Margaret Leibovic]

I think Felix's points in comment 1 make this a WONTFIX. It's too messy to try to restrict what characters are used in prefs, especially if there's no real reason for it.