Closed Bug 687916 Opened 10 years ago Closed 10 years ago

Add oedipus support to models

Categories

(support.mozilla.org :: Search, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
2011-10-18

People

(Reporter: erik, Assigned: willkg)

References

Details

(Whiteboard: [qa-])

oedipus needs a few pieces of metadata to support its nice API:

* that crc32() is our mapping from string → int
* the index names
* default field weights

Add these (via inner SphinxMeta classes) to our searchable models. You might also think about adding some constructs (like perhaps a singleton base oedipus.S sitting somewhere) to declare common filters for complex things like Documents.
Blocks: 687917
Blocks: 687927
Blocks: 687933
Target Milestone: 2011-10-04 → 2011-10-11
I'd prefer to let any singleton base classes and such emerge and get extracted rather than trying to design them up front. That usually yields better architecture. Thus, this bug should be limited to getting the SphinxMetas in place.
Grabificationalyzing this bug.
Assignee: nobody → willkg
Target Milestone: 2011-10-11 → 2011-10-18
At first, I started moving a lot of stuff into SphinxMeta classes on Thread, Question and Document, but then after talking with Erik, we decided it's better to just put the stuff that is Sphinx-specific and has no equivalent in Elastic in SphinxMeta.  Essentially, that's just index and filter_mapping.  Everything else will be arguments to the chain methods.

Fixed in https://github.com/jsocol/kitsune/commit/b725f62e349502dda2f99516d0e4a385e7301460
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: 2011-10-18 → 2011-10-11
Re-fixing the target milestone.
Target Milestone: 2011-10-11 → 2011-10-18
Please add steps for QA to verify, or mark as [qa-], thanks.
Sorry, this patch should be a noop, it shouldn't even be necessary to verify search still works for this guy in particular. It will be verified by subsequent bugs.
Whiteboard: [qa-]
Closed as [qa-]
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.