687933 - Port enormous, horrible search view to oedipus

Status: VERIFIED FIXED

(support.mozilla.org :: Search, defect)

Description

[Erik Rose [:erik][:erikrose]]

Port search.views.search from the search.clients API to oedipus. Lose a little piece of your soul as you futilely attempt to reverse-engineer dozens of pieces of state into some kind of comprehensible specification. Descend into irredeemable despair as your mind buckles under the cleaving weight of a thousand tangled couplings.

6 years experience with Windows Metro required. Sparkly crown with rubies in it a plus. Competitive pay.

(Actually, it probably won't be nearly that bad. 5th-circle-level at worst.)

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Takificationalyzing this one.  Will don heat-proof underwear before embarking.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

I'm fairly confident I can't finish this in the next day, so pushing it to 11-01-2011.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

Bumping this to 2011-11-08.

Comment 4

[Erik Rose [:erik][:erikrose]]

Ran into a performance problem where we'd be doing a DB hit for every matching result, not just every result displayed. We tuned oedipus to fix this. Now it will actually be better-performing that the current hand-written code, in that it will do a single DB query per model (at worst) per page for the result list rather than doing a separate query for each result displayed.

Comment 5

[Erik Rose [:erik][:erikrose]]

master: http://github.com/jsocol/kitsune/commit/26302fe

QA: Just spot-check to make sure search form (including Advanced Search) still works. Most of it is covered by automated tests.

Comment 6

[Rebecca Billings [:rbillings]]

Verified search returns results