687968 - Highlight the whole treerow on dragging/dropping

Status: RESOLVED FIXED

(Toolkit :: Themes, defect)

Description

[Richard Marti (:Paenglab)]

Now on dragging/dropping something on a treerow only the cell-text is highlighted. This makes it harder as needed to drop an element on the correct row.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: Use the whole row to highlight

This patch lets the -moz-tree-row highlight instead only the -moz-tree-cell-text. I removed the tree[seltype="cell"]... and tree[seltype="text"]... lines because I see no need for this selectors. The selector treechildren::-moz-tree-row(primary, dropOn) is enough. Checked on FX in Bookmarks window and on TB in FolderPane and AddressBook.

Comment 2

[Dão Gottwald [:dao]]

Could you pleaes attach before/after screenshots? Thanks!

Comment 3

[Richard Marti (:Paenglab)]

Attachment: Use the whole row to highlight v2

The ::-moz-tree-cell-text definitions are still needed for the highlight text color.

Comment 4

[Richard Marti (:Paenglab)]

Attachment: Comparison with before and after the patch

Comment 5

[Ed Morley [:emorley]]

Please could you tweak your hgrc to automatically add author info (guide here: http://blog.bonardo.net/2010/06/22/so-youre-about-to-use-checkin-needed) + add a commit message when attaching patches, since it makes pushing half a dozen checkin-neededs a lot easier. Thanks :-)

Comment 6

[Richard Marti (:Paenglab)]

Attachment: Use the whole row to highlight v2 for check-in

Same patch but with author and commit message.

Carrying over r+ from previous patch

Comment 7

[Dão Gottwald [:dao]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/c95fcdc98624

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/c95fcdc98624