Highlight the whole treerow on dragging/dropping

RESOLVED FIXED in mozilla11

Status

()

Toolkit
Themes
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

(Blocks: 1 bug)

Trunk
mozilla11
x86
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Assignee)

Description

7 years ago
Now on dragging/dropping something on a treerow only the cell-text is highlighted. This makes it harder as needed to drop an element on the correct row.
(Assignee)

Comment 1

7 years ago
Created attachment 561274 [details] [diff] [review]
Use the whole row to highlight

This patch lets the -moz-tree-row highlight instead only the -moz-tree-cell-text. I removed the tree[seltype="cell"]... and tree[seltype="text"]... lines because I see no need for this selectors. The selector treechildren::-moz-tree-row(primary, dropOn) is enough. Checked on FX in Bookmarks window and on TB in FolderPane and AddressBook.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #561274 - Flags: review?(dao)
(Assignee)

Updated

7 years ago
Blocks: 302109
Could you pleaes attach before/after screenshots? Thanks!
(Assignee)

Comment 3

7 years ago
Created attachment 561501 [details] [diff] [review]
Use the whole row to highlight v2

The ::-moz-tree-cell-text definitions are still needed for the highlight text color.
Attachment #561274 - Attachment is obsolete: true
Attachment #561274 - Flags: review?(dao)
Attachment #561501 - Flags: review?(dao)
(Assignee)

Comment 4

7 years ago
Created attachment 561502 [details]
Comparison with before and after the patch

Updated

7 years ago
Attachment #561501 - Flags: review?(dao) → review+
(Assignee)

Updated

7 years ago
Keywords: checkin-needed

Comment 5

7 years ago
Please could you tweak your hgrc to automatically add author info (guide here: http://blog.bonardo.net/2010/06/22/so-youre-about-to-use-checkin-needed) + add a commit message when attaching patches, since it makes pushing half a dozen checkin-neededs a lot easier. Thanks :-)
(Assignee)

Comment 6

7 years ago
Created attachment 574909 [details] [diff] [review]
Use the whole row to highlight v2 for check-in

Same patch but with author and commit message.

Carrying over r+ from previous patch
Attachment #561501 - Attachment is obsolete: true
Attachment #574909 - Flags: review+
http://hg.mozilla.org/integration/mozilla-inbound/rev/c95fcdc98624
Keywords: checkin-needed
Target Milestone: --- → mozilla11

Comment 8

7 years ago
https://hg.mozilla.org/mozilla-central/rev/c95fcdc98624
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.