688009 - [traceback] NO_SUCH_PERSON: Unable to locale 12c8db3e15 in the LDAP directory

Status: VERIFIED FIXED

(Participation Infrastructure :: Phonebook, defect, P2)

Description

[raymond [:retornam] (inactive)]

Traceback (most recent call last):

  File "/data/www/mozillians.allizom.org/mozillians/vendor/src/django/django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/data/www/mozillians.allizom.org/mozillians/apps/phonebook/views.py", line 106, in edit_new_profile
    return _edit_profile(request, unique_id, True)

  File "/data/www/mozillians.allizom.org/mozillians/apps/phonebook/views.py", line 111, in _edit_profile
    person = ldap.get_by_unique_id(unique_id)

  File "/data/www/mozillians.allizom.org/mozillians/apps/larper/__init__.py", line 173, in get_by_unique_id
    raise NO_SUCH_PERSON(msg % unique_id)

Comment 1

[Austin King [:ozten]]

I can't repro. Logically this could happen if there was a bug in the ldap connection pooling logic.

I've added some tests there and simplified
https://github.com/mozilla/mozillians/commit/32df0de38d323cecfb572606ccd7e3d493ae5129

Ultimately, we'll need Steps to Reproduce before we can act on this Traceback.

Comment 2

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Raymond,

Is this the intermittent errors on registration?

I can confirm if so, and give STR which is just going through registration :(

Personally I'd write a selenium script to run through it a few times til you trigger it.

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

1) A quick and easy repro case for me to hit this was:
A) Log in
B) Hit up a URL that's not yours, like https://mozillians.allizom.org/en-US/user/edit/cbac836cb6

2) Also, shouldn't this be "locate", rather than "locale".  I know, I know, minor nit.

Comment 4

[Austin King [:ozten]]

(In reply to Stephen Donner [:stephend] from comment #3)

> 2) Also, shouldn't this be "locate", rather than "locale".  I know, I know, minor nit.

Good call. http://git.io/pFYEGA

Comment 5

[[github robot]]

Commit pushed to https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/61559b7b40074a8fee40fe5a2ff09a9ccf8c0a4f
Catching failed lookup when a pending user tries to view or edit another person's profile. Fixes bug#688009

Comment 6

[Austin King [:ozten]]

(In reply to Stephen Donner [:stephend] from comment #3)

> A) Log in

A) Log in as a pending user

I've tweaked this to be a 404.

Comment 7

[Tobias (:Tobbi) Markus]

Verified this is a 404.