688056 - Cancelling auth process doesn't work as expected.

Status: RESOLVED FIXED

(Mozilla Labs :: F1, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

Eg, start a twitter auth.  In the popup dialog, locate and click on the "Cancel and return to app" link.  The login dialog changes to an error page "Server not found - Firefox can't find the server at oauthcallback.local." but instead the login dialog should close.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Attachment: Pointer to Github pull request: https://github.com/mozilla/oauthorizer/pull/2

Pointer to Github pull-request

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 561403 [details]
Pointer to Github pull request: https://github.com/mozilla/oauthorizer/pull/2

A couple other pull requests will be coming - this patch touches 3 repos!

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Attachment: Pointer to Github pull request: https://github.com/mozilla/fx-share-addon/pull/9

Pointer to Github pull-request

Comment 4

[Mark Hammond [:markh] [:mhammond]]

Attachment: Pointer to Github pull request: https://github.com/mozilla/openwebapps/pull/93

Pointer to Github pull-request

Comment 5

[Shane Caraveo (:mixedpuppy)]

merged:

https://github.com/mozilla/oauthorizer/commit/d641ed4203109f50f7dada600be7538d010ef9ec

https://github.com/mozilla/fx-share-addon/commit/80fe55b3317cfabc67c818278e498c27356046a7

https://github.com/mozilla/openwebapps/commit/92d02cef0c5e00defc1821922de66b469eb9bb53