688103 - [ja/ja-JP-mac] Add Twitter to the default search plugins

Status: VERIFIED FIXED

(Mozilla Localizations :: ja / Japanese, defect)

Description

[dynamis (Tomoya ASAI)]

en-US will add Twitter to the default search plugins (bug 671307).

ja/ja-JP-mac should also add Twitter search plugins but we should not use same one as en-US. Japanese Firefox users should search tweets in Japanese.

en-US's template url is:
https://twitter.com/search/{searchTerms}
But we should use following url:
https://twitter.com/search/lang%3Aja%20{searchTerms}

Is this url is OK or should we use some other parameters?
If the url is OK, I'll create, attach and twitter-ja search plugins and request approval for the change.

Comment 1

[Staś Małolepszy :stas]

Milos, can you take a look at this as I will be on vacation for the next few days?  Thanks!

Comment 2

[Axel Hecht [:Pike]]

Kev, would reducing the output on search to japanese do anything we need to be careful about?

Comment 3

[Kev Needham [:kev]]

I'll ask the Twitter team for guidance, I don't have the answer. Taking, and will hopefully have an update within 48 hrs.

Comment 4

[dynamis (Tomoya ASAI)]

Attachment: Twitter search plugin for ja

Twitter search plugin with "lang:ja" keyword by default for ja users.

(In reply to Kev [:kev] Needham from comment #3)
> I'll ask the Twitter team for guidance, I don't have the answer. Taking, and
> will hopefully have an update within 48 hrs.

Any update?
Please approve us to use this search-plugin.
# We want use this for Fx8 or later (push to both beta/aurora)

Comment 5

[dynamis (Tomoya ASAI)]

Attachment: Twitter search plugin for ja

Sorry, I attached different file (for mobile) and this is the right one for desktop.

Comment 6

[dynamis (Tomoya ASAI)]

Comment on attachment 567732 [details]
Twitter search plugin for ja

We need to commit this soon to include this into Firefox 8.

Stas, Could you check if this is technically ok?
Kev, any update with Twitter team?

Comment 7

[Kev Needham [:kev]]

Comment on attachment 567732 [details]
Twitter search plugin for ja

A thousand apologies, all. I thought I had approved & commented last week. Twitter confirmed tht the lang:ja flag was all that was needed.

Comment 8

[Kev Needham [:kev]]

Just a quick note that the plugin as-is will only search ja tweets. If search terms are entered in a language other than ja, the results will be pretty limited. Might be an idea to call that out in case people use it for multi-lingual queries.

Comment 9

[Gen Kanai [:gen]]

Dynamis, do you want to change the search plugin UI to reflect this?

Twitter（日本語）

or something like that?

Comment 10

[Kohei Yoshino [:kohei]]

(In reply to Gen Kanai [:gen] from comment #9)
> Dynamis, do you want to change the search plugin UI to reflect this?
> 
> Twitter（日本語）
> 
> or something like that?

I think the proposed "Twitter" is good.

Comment 11

[Axel Hecht [:Pike]]

Comment on attachment 567732 [details]
Twitter search plugin for ja

r=me, too. Please land with a comment referencing this bug and the reviews, like usual.

You probably want to land this up to the beta branch, and hit me with some sign-offs.

Comment 12

[dynamis (Tomoya ASAI)]

Thanks Kev and Axel!

pushed into ja/ja-JP-mac aurora/beta:
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ja/rev/b212f974a0e4
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ja-JP-mac/rev/3cf4b9906550
http://hg.mozilla.org/releases/l10n/mozilla-beta/ja/rev/959a96f45f5d
http://hg.mozilla.org/releases/l10n/mozilla-beta/ja-JP-mac/rev/429a5c365145

Comment 13

[Kev Needham [:kev]]

Just a final feedback I got from Twitter a couple minutes ago, there are a few ways to use their search facility. Don't know if you want to change anything, but they provided the following examples:

Japanese language Tweets with the search terms:
https://twitter.com/#!/search/{SearchTerms}%20lang%3Aja

Twitter's Japanese UI, searching for the search terms (any language results):
https://twitter.com/?lang=ja#!/search/{SearchTerms}

Twitter's Japanese UI, searching for the search terms (Japanese language Tweets):
https://twitter.com/?lang=ja#!/search/{SearchTerms}%20lang%3Aja

Apologies for the post-landing add, but just FYI if you want to update in a later release.

Comment 14

[dynamis (Tomoya ASAI)]

Thanks Kev and all,

UI language will be properly auto-detected and we just need set language of search results. So the search plugin I landed is OK.
If we want to update, I'll file another bug for the later releases.

And of course I've already verified with latest beta in the last week.
 -> verified fixed