688105 - Set 12 hour expiration on for_os and for_browser cookies

Status: VERIFIED FIXED

(support.mozilla.org :: Knowledge Base Software, task)

Description

[Scoobidiver (away)]

for_os and for_browser cookies expire at the end of a session. But at the next session, they are used.

If a user doesn't delete cookies when Firefox closes (most common behavior), he will get help for the OS/Fx versions when he came for the first time.

Comment 1

[Scoobidiver (away)]

It concerns users who selected once the selectors (to create the cookies) even if they went back to the initial values after.

Comment 2

[Kadir Topal [:atopal]]

Hmm, I'm not sure how common this is, but it is for sure confusing.

Comment 3

[James Socol [:jsocol, :james]]

Yeah, I've noticed this, too. I think it's an artifact of the modern browser world that "session" cookies are actually quite long-lived now. "At browser close" is really "when the browser decides to throw out the current session," which Firefox might not do...ever, if you're (un)lucky/careful.

Crystal's advice for similar bits of filter persistence was "about a day." I'd say let's set these cookies to a +12 hour expire, instead of "at browser close". That seems like a good balance.

Comment 4

[Ricky Rosario [:rrosario, :r1cky]]

https://github.com/jsocol/kitsune/commit/94f19bfc3028f1131f9036b2527b0738b2347976

Comment 5

[Rebecca Billings [:rbillings]]

Verified after long session, help for options were updated to what is currently installed